Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular expression ending in ? breaks highlighting #805

Closed
mjbvz opened this issue Feb 7, 2020 · 2 comments
Closed

Regular expression ending in ? breaks highlighting #805

mjbvz opened this issue Feb 7, 2020 · 2 comments

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Feb 7, 2020

From microsoft/vscode#90184

TS and JS Grammar Extension version: 0.0.53 / latest

Code

const x = !/s?/;
let foo;

After the regular expression, the highlighting is off:

Screen Shot 2020-02-07 at 11 28 22 AM

@zajrik
Copy link

zajrik commented Feb 14, 2020

I believe this is the similar to my issue (#806), in that it's actually fine if you remove the !:
image

@sheetalkamat
Copy link
Member

Yep fixed by d63aae4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants