Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awaited should be removed from keywords #874

Closed
Zzzen opened this issue Jun 30, 2021 · 4 comments
Closed

awaited should be removed from keywords #874

Zzzen opened this issue Jun 30, 2021 · 4 comments

Comments

@Zzzen
Copy link
Contributor

Zzzen commented Jun 30, 2021

TS and JS Grammar Extension version: 0.0.55 / latest

Code

// Please include a code snippet that demonstrates the issue
type N = awaited Promise<number>;
type NN = randomText Promise<number>;

image

awaited is highlighted incorrectly in vscode, which makes me think it's a keyword.

@orta
Copy link
Contributor

orta commented Jun 30, 2021

It is a keyword in TypeScript microsoft/TypeScript#35998 👍🏻

@orta orta closed this as completed Jun 30, 2021
@Zzzen
Copy link
Contributor Author

Zzzen commented Jun 30, 2021

😏 That's how I thought yesterday and got stuck by Cannot find name 'awaited'. But actually, it has been reverted. There no SyntaxKind.AwaitedKeyword anymore.

@orta orta reopened this Jun 30, 2021
@orta
Copy link
Contributor

orta commented Jun 30, 2021

Strange, there's still tests in the compiler for it... Or not! Now that I've looked in the latest main they're gone.

👍🏻

@orta
Copy link
Contributor

orta commented Jul 1, 2021

Thanks for the PR @Zzzen - fixed in #875

@orta orta closed this as completed Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants