Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Add padding to the menu on mobile #1623

Closed
j-f1 opened this issue Mar 7, 2021 · 3 comments
Closed

Idea: Add padding to the menu on mobile #1623

j-f1 opened this issue Mar 7, 2021 · 3 comments
Labels
Idea A way we can improve the site

Comments

@j-f1
Copy link

j-f1 commented Mar 7, 2021

Improvement Idea:

When the bottom bar in Safari is not visible, the handbook menu collides with the home indicator on iPhone. By adding padding using env(safe-area-inset-bottom), this can be remedied without adding excess padding in cases where the viewport is rectangular. See this WebKit blog post for more detail.

Why:

image

Alternative ideas:

Another option would be to move the menu to the top of the screen, since there is always some sort of top bar when using Safari.

@j-f1 j-f1 added the Idea A way we can improve the site label Mar 7, 2021
@orta
Copy link
Contributor

orta commented Mar 8, 2021

Interesting, I did take that into account #130 (comment) but something might have changed - do you know if it's always like this?

@j-f1
Copy link
Author

j-f1 commented Mar 8, 2021

I only just noticed the issue — I didn’t try any debugging steps.

@typescript-bot
Copy link
Collaborator

Hello! As per #2804, we are automatically closing all open issues. Please see #2804 for a description of what issues and PRs can be accepted going forward.

@typescript-bot typescript-bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Idea A way we can improve the site
Projects
None yet
Development

No branches or pull requests

3 participants