Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility improvements #2371

Closed
14 tasks
DanielRosenwasser opened this issue May 4, 2022 · 1 comment · Fixed by #2338
Closed
14 tasks

Accessibility improvements #2371

DanielRosenwasser opened this issue May 4, 2022 · 1 comment · Fixed by #2338
Labels
Accessibility Ensuring the site rocks for everyone

Comments

@DanielRosenwasser
Copy link
Member

We have an internal accessibility team at Microsoft which has been able to point out the following issues

  • TypeScriptLang.org_Community_AI4W: "H1" Heading level tag is not defined in the page.
  • TypeScriptLang.org_Index_AI4W:Ensures aria-hidden elements do not contain focusable elements (#playground-samples-popover)
  • TypeScriptLang.org_Tools_Playground_AI4W: Ensures that lists are structured correctly (#compiler-options-dropdown)
  • TypeScriptLang.org_Tools_Playground_AI4W: Ensures elements with an ARIA role that require child roles contain them (ol[role="tablist"])
  • TypeScriptLang.org_Tools_Playground_AI4W: Ensures elements with an ARIA role that require parent roles are contained by them (.selected.section-name.button)
  • TypeScriptLang.org_Tools_Playground_AI4W: Ensures every id attribute value of active elements is unique (div:nth-child(1))
  • TypeScriptLang.org_Tools_Playground_AI4W: Ensures <li> elements are used semantically (.active:nth-child(8))
  • TypeScriptLang.org_Documentation_Get Started_AI4W: Ensures the contrast between foreground and background colors meets WCAG 2 AA contrast ratio thresholds (span:nth-child(3))
  • TypeScriptLang.org_Documentation_Handbook_AI4W: Heading level tag is incorrectly defined in the page.
  • TypeScriptLang.org_Documentation_Handbook_Keyboard: on High Contrast mode the focus is not visible on which topic we are under "On this Page"
  • TypeScriptLang.org_Documentation_Handbook_Focus Order: Keyboard Focus is going on "like this page" which is incorrect focus order
  • TypeScriptLang.org_Documentation_Handbook_Focus Visible: Keyboard Focus is not visible when it reaches to "like the page" and "dislike the page"
  • TypeScriptLang.org-Web-Update Accessibility Conformance Documentation
  • TypeScript website _Index_Reflow: In reflow some controls are missing in the navigation bar(Download, Documentation, Handbook, Playground)
@DanielRosenwasser DanielRosenwasser added the Accessibility Ensuring the site rocks for everyone label May 4, 2022
@orta
Copy link
Contributor

orta commented May 5, 2022

TypeScript website _Index_Reflow: In reflow some controls are missing in the navigation bar(Download, Documentation, Handbook, Playground)

Is intentional those links are still accessible through other methods, they're just available quicker when there's space

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Ensuring the site rocks for everyone
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants