-
Notifications
You must be signed in to change notification settings - Fork 12.8k
/
Copy pathcontrolFlowAliasing.js
726 lines (682 loc) · 15.7 KB
/
controlFlowAliasing.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
//// [tests/cases/conformance/controlFlow/controlFlowAliasing.ts] ////
//// [controlFlowAliasing.ts]
// Narrowing by aliased conditional expressions
function f10(x: string | number) {
const isString = typeof x === "string";
if (isString) {
let t: string = x;
}
else {
let t: number = x;
}
}
function f11(x: unknown) {
const isString = typeof x === "string";
if (isString) {
let t: string = x;
}
}
function f12(x: string | number | boolean) {
const isString = typeof x === "string";
const isNumber = typeof x === "number";
if (isString || isNumber) {
let t: string | number = x;
}
else {
let t: boolean = x;
}
}
function f13(x: string | number | boolean) {
const isString = typeof x === "string";
const isNumber = typeof x === "number";
const isStringOrNumber = isString || isNumber;
if (isStringOrNumber) {
let t: string | number = x;
}
else {
let t: boolean = x;
}
}
function f14(x: number | null | undefined): number | null {
const notUndefined = x !== undefined;
return notUndefined ? x : 0;
}
function f15(obj: { readonly x: string | number }) {
const isString = typeof obj.x === 'string';
if (isString) {
let s: string = obj.x;
}
}
function f16(obj: { readonly x: string | number }) {
const isString = typeof obj.x === 'string';
obj = { x: 42 };
if (isString) {
let s: string = obj.x; // Not narrowed because of is assigned in function body
}
}
function f17(obj: readonly [string | number]) {
const isString = typeof obj[0] === 'string';
if (isString) {
let s: string = obj[0];
}
}
function f18(obj: readonly [string | number]) {
const isString = typeof obj[0] === 'string';
obj = [42];
if (isString) {
let s: string = obj[0]; // Not narrowed because of is assigned in function body
}
}
function f20(obj: { kind: 'foo', foo: string } | { kind: 'bar', bar: number }) {
const isFoo = obj.kind === 'foo';
if (isFoo) {
obj.foo;
}
else {
obj.bar;
}
}
function f21(obj: { kind: 'foo', foo: string } | { kind: 'bar', bar: number }) {
const isFoo: boolean = obj.kind === 'foo';
if (isFoo) {
obj.foo; // Not narrowed because isFoo has type annotation
}
else {
obj.bar; // Not narrowed because isFoo has type annotation
}
}
function f22(obj: { kind: 'foo', foo: string } | { kind: 'bar', bar: number }) {
let isFoo = obj.kind === 'foo';
if (isFoo) {
obj.foo; // Not narrowed because isFoo is mutable
}
else {
obj.bar; // Not narrowed because isFoo is mutable
}
}
function f23(obj: { kind: 'foo', foo: string } | { kind: 'bar', bar: number }) {
const isFoo = obj.kind === 'foo';
obj = obj;
if (isFoo) {
obj.foo; // Not narrowed because obj is assigned in function body
}
else {
obj.bar; // Not narrowed because obj is assigned in function body
}
}
function f24(arg: { kind: 'foo', foo: string } | { kind: 'bar', bar: number }) {
const obj = arg;
const isFoo = obj.kind === 'foo';
if (isFoo) {
obj.foo;
}
else {
obj.bar;
}
}
function f25(arg: { kind: 'foo', foo: string } | { kind: 'bar', bar: number }) {
let obj = arg;
const isFoo = obj.kind === 'foo';
if (isFoo) {
obj.foo;
}
else {
obj.bar;
}
}
function f26(outer: { readonly obj: { kind: 'foo', foo: string } | { kind: 'bar', bar: number } }) {
const isFoo = outer.obj.kind === 'foo';
if (isFoo) {
outer.obj.foo;
}
else {
outer.obj.bar;
}
}
function f27(outer: { obj: { kind: 'foo', foo: string } | { kind: 'bar', bar: number } }) {
const isFoo = outer.obj.kind === 'foo';
if (isFoo) {
outer.obj.foo; // Not narrowed because obj is mutable
}
else {
outer.obj.bar; // Not narrowed because obj is mutable
}
}
function f28(obj?: { kind: 'foo', foo: string } | { kind: 'bar', bar: number }) {
const isFoo = obj && obj.kind === 'foo';
const isBar = obj && obj.kind === 'bar';
if (isFoo) {
obj.foo;
}
if (isBar) {
obj.bar;
}
}
// Narrowing by aliased discriminant property access
function f30(obj: { kind: 'foo', foo: string } | { kind: 'bar', bar: number }) {
const kind = obj.kind;
if (kind === 'foo') {
obj.foo;
}
else {
obj.bar;
}
}
function f31(obj: { kind: 'foo', foo: string } | { kind: 'bar', bar: number }) {
const { kind } = obj;
if (kind === 'foo') {
obj.foo;
}
else {
obj.bar;
}
}
function f32(obj: { kind: 'foo', foo: string } | { kind: 'bar', bar: number }) {
const { kind: k } = obj;
if (k === 'foo') {
obj.foo;
}
else {
obj.bar;
}
}
function f33(obj: { kind: 'foo', foo: string } | { kind: 'bar', bar: number }) {
const { kind } = obj;
switch (kind) {
case 'foo': obj.foo; break;
case 'bar': obj.bar; break;
}
}
class C10 {
constructor(readonly x: string | number) {
const thisX_isString = typeof this.x === 'string';
const xIsString = typeof x === 'string';
if (thisX_isString && xIsString) {
let s: string;
s = this.x;
s = x;
}
}
}
class C11 {
constructor(readonly x: string | number) {
const thisX_isString = typeof this.x === 'string';
const xIsString = typeof x === 'string';
if (thisX_isString && xIsString) {
// Some narrowings may be invalidated due to later assignments.
let s: string;
s = this.x;
s = x;
}
else {
this.x = 10;
x = 10;
}
}
}
// Mixing of aliased discriminants and conditionals
function f40(obj: { kind: 'foo', foo?: string } | { kind: 'bar', bar?: number }) {
const { kind } = obj;
const isFoo = kind == 'foo';
if (isFoo && obj.foo) {
let t: string = obj.foo;
}
}
// Unsupported narrowing of destructured payload by destructured discriminant
type Data = { kind: 'str', payload: string } | { kind: 'num', payload: number };
function gg2(obj: Data) {
if (obj.kind === 'str') {
let t: string = obj.payload;
}
else {
let t: number = obj.payload;
}
}
function foo({ kind, payload }: Data) {
if (kind === 'str') {
let t: string = payload;
}
else {
let t: number = payload;
}
}
// Repro from #45830
const obj = {
fn: () => true
};
if (a) { }
const a = obj.fn();
// repro from https://github.com/microsoft/TypeScript/issues/53267
class Utils {
static isDefined<T>(value: T): value is NonNullable<T> {
return value != null;
}
}
class A53267 {
public readonly testNumber: number | undefined;
foo() {
const isNumber = Utils.isDefined(this.testNumber);
if (isNumber) {
const x: number = this.testNumber;
}
}
}
//// [controlFlowAliasing.js]
"use strict";
// Narrowing by aliased conditional expressions
function f10(x) {
var isString = typeof x === "string";
if (isString) {
var t = x;
}
else {
var t = x;
}
}
function f11(x) {
var isString = typeof x === "string";
if (isString) {
var t = x;
}
}
function f12(x) {
var isString = typeof x === "string";
var isNumber = typeof x === "number";
if (isString || isNumber) {
var t = x;
}
else {
var t = x;
}
}
function f13(x) {
var isString = typeof x === "string";
var isNumber = typeof x === "number";
var isStringOrNumber = isString || isNumber;
if (isStringOrNumber) {
var t = x;
}
else {
var t = x;
}
}
function f14(x) {
var notUndefined = x !== undefined;
return notUndefined ? x : 0;
}
function f15(obj) {
var isString = typeof obj.x === 'string';
if (isString) {
var s = obj.x;
}
}
function f16(obj) {
var isString = typeof obj.x === 'string';
obj = { x: 42 };
if (isString) {
var s = obj.x; // Not narrowed because of is assigned in function body
}
}
function f17(obj) {
var isString = typeof obj[0] === 'string';
if (isString) {
var s = obj[0];
}
}
function f18(obj) {
var isString = typeof obj[0] === 'string';
obj = [42];
if (isString) {
var s = obj[0]; // Not narrowed because of is assigned in function body
}
}
function f20(obj) {
var isFoo = obj.kind === 'foo';
if (isFoo) {
obj.foo;
}
else {
obj.bar;
}
}
function f21(obj) {
var isFoo = obj.kind === 'foo';
if (isFoo) {
obj.foo; // Not narrowed because isFoo has type annotation
}
else {
obj.bar; // Not narrowed because isFoo has type annotation
}
}
function f22(obj) {
var isFoo = obj.kind === 'foo';
if (isFoo) {
obj.foo; // Not narrowed because isFoo is mutable
}
else {
obj.bar; // Not narrowed because isFoo is mutable
}
}
function f23(obj) {
var isFoo = obj.kind === 'foo';
obj = obj;
if (isFoo) {
obj.foo; // Not narrowed because obj is assigned in function body
}
else {
obj.bar; // Not narrowed because obj is assigned in function body
}
}
function f24(arg) {
var obj = arg;
var isFoo = obj.kind === 'foo';
if (isFoo) {
obj.foo;
}
else {
obj.bar;
}
}
function f25(arg) {
var obj = arg;
var isFoo = obj.kind === 'foo';
if (isFoo) {
obj.foo;
}
else {
obj.bar;
}
}
function f26(outer) {
var isFoo = outer.obj.kind === 'foo';
if (isFoo) {
outer.obj.foo;
}
else {
outer.obj.bar;
}
}
function f27(outer) {
var isFoo = outer.obj.kind === 'foo';
if (isFoo) {
outer.obj.foo; // Not narrowed because obj is mutable
}
else {
outer.obj.bar; // Not narrowed because obj is mutable
}
}
function f28(obj) {
var isFoo = obj && obj.kind === 'foo';
var isBar = obj && obj.kind === 'bar';
if (isFoo) {
obj.foo;
}
if (isBar) {
obj.bar;
}
}
// Narrowing by aliased discriminant property access
function f30(obj) {
var kind = obj.kind;
if (kind === 'foo') {
obj.foo;
}
else {
obj.bar;
}
}
function f31(obj) {
var kind = obj.kind;
if (kind === 'foo') {
obj.foo;
}
else {
obj.bar;
}
}
function f32(obj) {
var k = obj.kind;
if (k === 'foo') {
obj.foo;
}
else {
obj.bar;
}
}
function f33(obj) {
var kind = obj.kind;
switch (kind) {
case 'foo':
obj.foo;
break;
case 'bar':
obj.bar;
break;
}
}
var C10 = /** @class */ (function () {
function C10(x) {
this.x = x;
var thisX_isString = typeof this.x === 'string';
var xIsString = typeof x === 'string';
if (thisX_isString && xIsString) {
var s = void 0;
s = this.x;
s = x;
}
}
return C10;
}());
var C11 = /** @class */ (function () {
function C11(x) {
this.x = x;
var thisX_isString = typeof this.x === 'string';
var xIsString = typeof x === 'string';
if (thisX_isString && xIsString) {
// Some narrowings may be invalidated due to later assignments.
var s = void 0;
s = this.x;
s = x;
}
else {
this.x = 10;
x = 10;
}
}
return C11;
}());
// Mixing of aliased discriminants and conditionals
function f40(obj) {
var kind = obj.kind;
var isFoo = kind == 'foo';
if (isFoo && obj.foo) {
var t = obj.foo;
}
}
function gg2(obj) {
if (obj.kind === 'str') {
var t = obj.payload;
}
else {
var t = obj.payload;
}
}
function foo(_a) {
var kind = _a.kind, payload = _a.payload;
if (kind === 'str') {
var t = payload;
}
else {
var t = payload;
}
}
// Repro from #45830
var obj = {
fn: function () { return true; }
};
if (a) { }
var a = obj.fn();
// repro from https://github.com/microsoft/TypeScript/issues/53267
var Utils = /** @class */ (function () {
function Utils() {
}
Utils.isDefined = function (value) {
return value != null;
};
return Utils;
}());
var A53267 = /** @class */ (function () {
function A53267() {
}
A53267.prototype.foo = function () {
var isNumber = Utils.isDefined(this.testNumber);
if (isNumber) {
var x = this.testNumber;
}
};
return A53267;
}());
//// [controlFlowAliasing.d.ts]
declare function f10(x: string | number): void;
declare function f11(x: unknown): void;
declare function f12(x: string | number | boolean): void;
declare function f13(x: string | number | boolean): void;
declare function f14(x: number | null | undefined): number | null;
declare function f15(obj: {
readonly x: string | number;
}): void;
declare function f16(obj: {
readonly x: string | number;
}): void;
declare function f17(obj: readonly [string | number]): void;
declare function f18(obj: readonly [string | number]): void;
declare function f20(obj: {
kind: 'foo';
foo: string;
} | {
kind: 'bar';
bar: number;
}): void;
declare function f21(obj: {
kind: 'foo';
foo: string;
} | {
kind: 'bar';
bar: number;
}): void;
declare function f22(obj: {
kind: 'foo';
foo: string;
} | {
kind: 'bar';
bar: number;
}): void;
declare function f23(obj: {
kind: 'foo';
foo: string;
} | {
kind: 'bar';
bar: number;
}): void;
declare function f24(arg: {
kind: 'foo';
foo: string;
} | {
kind: 'bar';
bar: number;
}): void;
declare function f25(arg: {
kind: 'foo';
foo: string;
} | {
kind: 'bar';
bar: number;
}): void;
declare function f26(outer: {
readonly obj: {
kind: 'foo';
foo: string;
} | {
kind: 'bar';
bar: number;
};
}): void;
declare function f27(outer: {
obj: {
kind: 'foo';
foo: string;
} | {
kind: 'bar';
bar: number;
};
}): void;
declare function f28(obj?: {
kind: 'foo';
foo: string;
} | {
kind: 'bar';
bar: number;
}): void;
declare function f30(obj: {
kind: 'foo';
foo: string;
} | {
kind: 'bar';
bar: number;
}): void;
declare function f31(obj: {
kind: 'foo';
foo: string;
} | {
kind: 'bar';
bar: number;
}): void;
declare function f32(obj: {
kind: 'foo';
foo: string;
} | {
kind: 'bar';
bar: number;
}): void;
declare function f33(obj: {
kind: 'foo';
foo: string;
} | {
kind: 'bar';
bar: number;
}): void;
declare class C10 {
readonly x: string | number;
constructor(x: string | number);
}
declare class C11 {
readonly x: string | number;
constructor(x: string | number);
}
declare function f40(obj: {
kind: 'foo';
foo?: string;
} | {
kind: 'bar';
bar?: number;
}): void;
type Data = {
kind: 'str';
payload: string;
} | {
kind: 'num';
payload: number;
};
declare function gg2(obj: Data): void;
declare function foo({ kind, payload }: Data): void;
declare const obj: {
fn: () => boolean;
};
declare const a: boolean;
declare class Utils {
static isDefined<T>(value: T): value is NonNullable<T>;
}
declare class A53267 {
readonly testNumber: number | undefined;
foo(): void;
}