Skip to content

Commit 11b2930

Browse files
rbucktonrbuckton
authored
Add compatible overloads that accept ArrayBuffer to BigInt64Array/BigUint64Array (#60391)
1 parent 248c8f5 commit 11b2930

File tree

3 files changed

+86
-57
lines changed

3 files changed

+86
-57
lines changed

‎src/lib/es2020.bigint.d.ts

+2
Original file line numberDiff line numberDiff line change
@@ -373,6 +373,7 @@ interface BigInt64ArrayConstructor {
373373
new (length?: number): BigInt64Array<ArrayBuffer>;
374374
new (array: ArrayLike<bigint> | Iterable<bigint>): BigInt64Array<ArrayBuffer>;
375375
new <TArrayBuffer extends ArrayBufferLike = ArrayBuffer>(buffer: TArrayBuffer, byteOffset?: number, length?: number): BigInt64Array<TArrayBuffer>;
376+
new (array: ArrayLike<bigint> | ArrayBuffer): BigInt64Array<ArrayBuffer>;
376377

377378
/** The size in bytes of each element in the array. */
378379
readonly BYTES_PER_ELEMENT: number;
@@ -649,6 +650,7 @@ interface BigUint64ArrayConstructor {
649650
new (length?: number): BigUint64Array<ArrayBuffer>;
650651
new (array: ArrayLike<bigint> | Iterable<bigint>): BigUint64Array<ArrayBuffer>;
651652
new <TArrayBuffer extends ArrayBufferLike = ArrayBuffer>(buffer: TArrayBuffer, byteOffset?: number, length?: number): BigUint64Array<TArrayBuffer>;
653+
new (array: ArrayLike<bigint> | ArrayBuffer): BigUint64Array<ArrayBuffer>;
652654

653655
/** The size in bytes of each element in the array. */
654656
readonly BYTES_PER_ELEMENT: number;

‎tests/baselines/reference/bigintWithLib.errors.txt

+71-57
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,41 @@
11
bigintWithLib.ts(4,1): error TS2350: Only a void function can be called with the 'new' keyword.
2-
bigintWithLib.ts(19,33): error TS2769: No overload matches this call.
3-
Overload 1 of 3, '(length?: number): BigInt64Array<ArrayBuffer>', gave the following error.
4-
Argument of type 'number[]' is not assignable to parameter of type 'number'.
5-
Overload 2 of 3, '(array: ArrayLike<bigint> | Iterable<bigint>): BigInt64Array<ArrayBuffer>', gave the following error.
6-
Argument of type 'number[]' is not assignable to parameter of type 'ArrayLike<bigint> | Iterable<bigint>'.
7-
Type 'number[]' is not assignable to type 'Iterable<bigint>'.
8-
The types returned by '[Symbol.iterator]().next(...)' are incompatible between these types.
9-
Type 'IteratorResult<number, any>' is not assignable to type 'IteratorResult<bigint, any>'.
10-
Type 'IteratorYieldResult<number>' is not assignable to type 'IteratorResult<bigint, any>'.
11-
Type 'IteratorYieldResult<number>' is not assignable to type 'IteratorYieldResult<bigint>'.
12-
Type 'number' is not assignable to type 'bigint'.
13-
Overload 3 of 3, '(buffer: ArrayBufferLike, byteOffset?: number, length?: number): BigInt64Array<ArrayBufferLike>', gave the following error.
14-
Argument of type 'number[]' is not assignable to parameter of type 'ArrayBufferLike'.
15-
Type 'number[]' is missing the following properties from type 'SharedArrayBuffer': byteLength, [Symbol.species], [Symbol.toStringTag]
2+
bigintWithLib.ts(19,34): error TS2769: No overload matches this call.
3+
The last overload gave the following error.
4+
Type 'number' is not assignable to type 'bigint'.
5+
Type 'number' is not assignable to type 'bigint'.
6+
Type 'number' is not assignable to type 'bigint'.
7+
bigintWithLib.ts(19,37): error TS2769: No overload matches this call.
8+
The last overload gave the following error.
9+
Type 'number' is not assignable to type 'bigint'.
10+
Type 'number' is not assignable to type 'bigint'.
11+
Type 'number' is not assignable to type 'bigint'.
12+
bigintWithLib.ts(19,40): error TS2769: No overload matches this call.
13+
The last overload gave the following error.
14+
Type 'number' is not assignable to type 'bigint'.
15+
Type 'number' is not assignable to type 'bigint'.
16+
Type 'number' is not assignable to type 'bigint'.
1617
bigintWithLib.ts(24,13): error TS2540: Cannot assign to 'length' because it is a read-only property.
17-
bigintWithLib.ts(31,35): error TS2769: No overload matches this call.
18-
Overload 1 of 3, '(length?: number): BigUint64Array<ArrayBuffer>', gave the following error.
19-
Argument of type 'number[]' is not assignable to parameter of type 'number'.
20-
Overload 2 of 3, '(array: ArrayLike<bigint> | Iterable<bigint>): BigUint64Array<ArrayBuffer>', gave the following error.
21-
Argument of type 'number[]' is not assignable to parameter of type 'ArrayLike<bigint> | Iterable<bigint>'.
22-
Type 'number[]' is not assignable to type 'Iterable<bigint>'.
23-
The types returned by '[Symbol.iterator]().next(...)' are incompatible between these types.
24-
Type 'IteratorResult<number, any>' is not assignable to type 'IteratorResult<bigint, any>'.
25-
Type 'IteratorYieldResult<number>' is not assignable to type 'IteratorResult<bigint, any>'.
26-
Type 'IteratorYieldResult<number>' is not assignable to type 'IteratorYieldResult<bigint>'.
27-
Type 'number' is not assignable to type 'bigint'.
28-
Overload 3 of 3, '(buffer: ArrayBufferLike, byteOffset?: number, length?: number): BigUint64Array<ArrayBufferLike>', gave the following error.
29-
Argument of type 'number[]' is not assignable to parameter of type 'ArrayBufferLike'.
30-
Type 'number[]' is missing the following properties from type 'SharedArrayBuffer': byteLength, [Symbol.species], [Symbol.toStringTag]
18+
bigintWithLib.ts(31,36): error TS2769: No overload matches this call.
19+
The last overload gave the following error.
20+
Type 'number' is not assignable to type 'bigint'.
21+
Type 'number' is not assignable to type 'bigint'.
22+
Type 'number' is not assignable to type 'bigint'.
23+
bigintWithLib.ts(31,39): error TS2769: No overload matches this call.
24+
The last overload gave the following error.
25+
Type 'number' is not assignable to type 'bigint'.
26+
Type 'number' is not assignable to type 'bigint'.
27+
Type 'number' is not assignable to type 'bigint'.
28+
bigintWithLib.ts(31,42): error TS2769: No overload matches this call.
29+
The last overload gave the following error.
30+
Type 'number' is not assignable to type 'bigint'.
31+
Type 'number' is not assignable to type 'bigint'.
32+
Type 'number' is not assignable to type 'bigint'.
3133
bigintWithLib.ts(36,13): error TS2540: Cannot assign to 'length' because it is a read-only property.
3234
bigintWithLib.ts(43,25): error TS2345: Argument of type 'number' is not assignable to parameter of type 'bigint'.
3335
bigintWithLib.ts(46,26): error TS2345: Argument of type 'number' is not assignable to parameter of type 'bigint'.
3436

3537

36-
==== bigintWithLib.ts (7 errors) ====
38+
==== bigintWithLib.ts (11 errors) ====
3739
// Test BigInt functions
3840
let bigintVal: bigint = BigInt(123);
3941
bigintVal = BigInt("456");
@@ -55,21 +57,27 @@ bigintWithLib.ts(46,26): error TS2345: Argument of type 'number' is not assignab
5557
bigIntArray = new BigInt64Array(10);
5658
bigIntArray = new BigInt64Array([1n, 2n, 3n]);
5759
bigIntArray = new BigInt64Array([1, 2, 3]); // should error
58-
~~~~~~~~~
60+
~
5961
!!! error TS2769: No overload matches this call.
60-
!!! error TS2769: Overload 1 of 3, '(length?: number): BigInt64Array<ArrayBuffer>', gave the following error.
61-
!!! error TS2769: Argument of type 'number[]' is not assignable to parameter of type 'number'.
62-
!!! error TS2769: Overload 2 of 3, '(array: ArrayLike<bigint> | Iterable<bigint>): BigInt64Array<ArrayBuffer>', gave the following error.
63-
!!! error TS2769: Argument of type 'number[]' is not assignable to parameter of type 'ArrayLike<bigint> | Iterable<bigint>'.
64-
!!! error TS2769: Type 'number[]' is not assignable to type 'Iterable<bigint>'.
65-
!!! error TS2769: The types returned by '[Symbol.iterator]().next(...)' are incompatible between these types.
66-
!!! error TS2769: Type 'IteratorResult<number, any>' is not assignable to type 'IteratorResult<bigint, any>'.
67-
!!! error TS2769: Type 'IteratorYieldResult<number>' is not assignable to type 'IteratorResult<bigint, any>'.
68-
!!! error TS2769: Type 'IteratorYieldResult<number>' is not assignable to type 'IteratorYieldResult<bigint>'.
69-
!!! error TS2769: Type 'number' is not assignable to type 'bigint'.
70-
!!! error TS2769: Overload 3 of 3, '(buffer: ArrayBufferLike, byteOffset?: number, length?: number): BigInt64Array<ArrayBufferLike>', gave the following error.
71-
!!! error TS2769: Argument of type 'number[]' is not assignable to parameter of type 'ArrayBufferLike'.
72-
!!! error TS2769: Type 'number[]' is missing the following properties from type 'SharedArrayBuffer': byteLength, [Symbol.species], [Symbol.toStringTag]
62+
!!! error TS2769: The last overload gave the following error.
63+
!!! error TS2769: Type 'number' is not assignable to type 'bigint'.
64+
!!! error TS2769: Type 'number' is not assignable to type 'bigint'.
65+
!!! error TS2769: Type 'number' is not assignable to type 'bigint'.
66+
!!! related TS2771 lib.es2020.bigint.d.ts:--:--: The last overload is declared here.
67+
~
68+
!!! error TS2769: No overload matches this call.
69+
!!! error TS2769: The last overload gave the following error.
70+
!!! error TS2769: Type 'number' is not assignable to type 'bigint'.
71+
!!! error TS2769: Type 'number' is not assignable to type 'bigint'.
72+
!!! error TS2769: Type 'number' is not assignable to type 'bigint'.
73+
!!! related TS2771 lib.es2020.bigint.d.ts:--:--: The last overload is declared here.
74+
~
75+
!!! error TS2769: No overload matches this call.
76+
!!! error TS2769: The last overload gave the following error.
77+
!!! error TS2769: Type 'number' is not assignable to type 'bigint'.
78+
!!! error TS2769: Type 'number' is not assignable to type 'bigint'.
79+
!!! error TS2769: Type 'number' is not assignable to type 'bigint'.
80+
!!! related TS2771 lib.es2020.bigint.d.ts:--:--: The last overload is declared here.
7381
bigIntArray = new BigInt64Array(new ArrayBuffer(80));
7482
bigIntArray = new BigInt64Array(new ArrayBuffer(80), 8);
7583
bigIntArray = new BigInt64Array(new ArrayBuffer(80), 8, 3);
@@ -84,21 +92,27 @@ bigintWithLib.ts(46,26): error TS2345: Argument of type 'number' is not assignab
8492
bigUintArray = new BigUint64Array(10);
8593
bigUintArray = new BigUint64Array([1n, 2n, 3n]);
8694
bigUintArray = new BigUint64Array([1, 2, 3]); // should error
87-
~~~~~~~~~
95+
~
96+
!!! error TS2769: No overload matches this call.
97+
!!! error TS2769: The last overload gave the following error.
98+
!!! error TS2769: Type 'number' is not assignable to type 'bigint'.
99+
!!! error TS2769: Type 'number' is not assignable to type 'bigint'.
100+
!!! error TS2769: Type 'number' is not assignable to type 'bigint'.
101+
!!! related TS2771 lib.es2020.bigint.d.ts:--:--: The last overload is declared here.
102+
~
103+
!!! error TS2769: No overload matches this call.
104+
!!! error TS2769: The last overload gave the following error.
105+
!!! error TS2769: Type 'number' is not assignable to type 'bigint'.
106+
!!! error TS2769: Type 'number' is not assignable to type 'bigint'.
107+
!!! error TS2769: Type 'number' is not assignable to type 'bigint'.
108+
!!! related TS2771 lib.es2020.bigint.d.ts:--:--: The last overload is declared here.
109+
~
88110
!!! error TS2769: No overload matches this call.
89-
!!! error TS2769: Overload 1 of 3, '(length?: number): BigUint64Array<ArrayBuffer>', gave the following error.
90-
!!! error TS2769: Argument of type 'number[]' is not assignable to parameter of type 'number'.
91-
!!! error TS2769: Overload 2 of 3, '(array: ArrayLike<bigint> | Iterable<bigint>): BigUint64Array<ArrayBuffer>', gave the following error.
92-
!!! error TS2769: Argument of type 'number[]' is not assignable to parameter of type 'ArrayLike<bigint> | Iterable<bigint>'.
93-
!!! error TS2769: Type 'number[]' is not assignable to type 'Iterable<bigint>'.
94-
!!! error TS2769: The types returned by '[Symbol.iterator]().next(...)' are incompatible between these types.
95-
!!! error TS2769: Type 'IteratorResult<number, any>' is not assignable to type 'IteratorResult<bigint, any>'.
96-
!!! error TS2769: Type 'IteratorYieldResult<number>' is not assignable to type 'IteratorResult<bigint, any>'.
97-
!!! error TS2769: Type 'IteratorYieldResult<number>' is not assignable to type 'IteratorYieldResult<bigint>'.
98-
!!! error TS2769: Type 'number' is not assignable to type 'bigint'.
99-
!!! error TS2769: Overload 3 of 3, '(buffer: ArrayBufferLike, byteOffset?: number, length?: number): BigUint64Array<ArrayBufferLike>', gave the following error.
100-
!!! error TS2769: Argument of type 'number[]' is not assignable to parameter of type 'ArrayBufferLike'.
101-
!!! error TS2769: Type 'number[]' is missing the following properties from type 'SharedArrayBuffer': byteLength, [Symbol.species], [Symbol.toStringTag]
111+
!!! error TS2769: The last overload gave the following error.
112+
!!! error TS2769: Type 'number' is not assignable to type 'bigint'.
113+
!!! error TS2769: Type 'number' is not assignable to type 'bigint'.
114+
!!! error TS2769: Type 'number' is not assignable to type 'bigint'.
115+
!!! related TS2771 lib.es2020.bigint.d.ts:--:--: The last overload is declared here.
102116
bigUintArray = new BigUint64Array(new ArrayBuffer(80));
103117
bigUintArray = new BigUint64Array(new ArrayBuffer(80), 8);
104118
bigUintArray = new BigUint64Array(new ArrayBuffer(80), 8, 3);

‎tests/cases/compiler/typedArrayConstructorOverloads.ts

+13
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
// @target: esnext
2+
// @noEmit: true
3+
// @noTypesAndSymbols: true
4+
5+
// https://github.com/microsoft/TypeScript/issues/60367
6+
7+
type TypedArrayConstructor =
8+
| Float64ArrayConstructor
9+
| BigInt64ArrayConstructor
10+
11+
export function makeTypedArray(buffer: ArrayBuffer, ctr: TypedArrayConstructor) {
12+
return new ctr(buffer);
13+
}

0 commit comments

Comments
 (0)