Skip to content

Commit 6a89972

Browse files
RyanCavanaughRyanCavanaugh
committed
Lint
1 parent a399e8d commit 6a89972

File tree

48 files changed

+243
-225
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+243
-225
lines changed

‎src/compiler/checker.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13321,7 +13321,7 @@ namespace ts {
1332113321
return true;
1332213322
}
1332313323
return false;
13324-
13324+
1332513325
// Some forms listed here for clarity
1332613326
case SyntaxKind.VoidExpression: // Explicit opt-out
1332713327
case SyntaxKind.TypeAssertionExpression: // Not SEF, but can produce useful type warnings

‎tests/baselines/reference/assignmentToParenthesizedExpression1.errors.txt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
tests/cases/compiler/assignmentToParenthesizedExpression1.ts(2,1): error TS2364: Invalid left-hand side of assignment expression.
2-
tests/cases/compiler/assignmentToParenthesizedExpression1.ts(2,2): error TS2693: Left side of comma operator is unused and has no side effects.
2+
tests/cases/compiler/assignmentToParenthesizedExpression1.ts(2,2): error TS2695: Left side of comma operator is unused and has no side effects.
33

44

55
==== tests/cases/compiler/assignmentToParenthesizedExpression1.ts (2 errors) ====
@@ -8,4 +8,4 @@ tests/cases/compiler/assignmentToParenthesizedExpression1.ts(2,2): error TS2693:
88
~~~~~~
99
!!! error TS2364: Invalid left-hand side of assignment expression.
1010
~
11-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
11+
!!! error TS2695: Left side of comma operator is unused and has no side effects.

‎tests/baselines/reference/commaOperator1.errors.txt‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,33 @@
1-
tests/cases/compiler/commaOperator1.ts(1,11): error TS2693: Left side of comma operator is unused and has no side effects.
2-
tests/cases/compiler/commaOperator1.ts(1,11): error TS2693: Left side of comma operator is unused and has no side effects.
3-
tests/cases/compiler/commaOperator1.ts(1,11): error TS2693: Left side of comma operator is unused and has no side effects.
4-
tests/cases/compiler/commaOperator1.ts(1,12): error TS2693: Left side of comma operator is unused and has no side effects.
5-
tests/cases/compiler/commaOperator1.ts(1,12): error TS2693: Left side of comma operator is unused and has no side effects.
6-
tests/cases/compiler/commaOperator1.ts(1,29): error TS2693: Left side of comma operator is unused and has no side effects.
7-
tests/cases/compiler/commaOperator1.ts(4,12): error TS2693: Left side of comma operator is unused and has no side effects.
8-
tests/cases/compiler/commaOperator1.ts(4,12): error TS2693: Left side of comma operator is unused and has no side effects.
1+
tests/cases/compiler/commaOperator1.ts(1,11): error TS2695: Left side of comma operator is unused and has no side effects.
2+
tests/cases/compiler/commaOperator1.ts(1,11): error TS2695: Left side of comma operator is unused and has no side effects.
3+
tests/cases/compiler/commaOperator1.ts(1,11): error TS2695: Left side of comma operator is unused and has no side effects.
4+
tests/cases/compiler/commaOperator1.ts(1,12): error TS2695: Left side of comma operator is unused and has no side effects.
5+
tests/cases/compiler/commaOperator1.ts(1,12): error TS2695: Left side of comma operator is unused and has no side effects.
6+
tests/cases/compiler/commaOperator1.ts(1,29): error TS2695: Left side of comma operator is unused and has no side effects.
7+
tests/cases/compiler/commaOperator1.ts(4,12): error TS2695: Left side of comma operator is unused and has no side effects.
8+
tests/cases/compiler/commaOperator1.ts(4,12): error TS2695: Left side of comma operator is unused and has no side effects.
99

1010

1111
==== tests/cases/compiler/commaOperator1.ts (8 errors) ====
1212
var v1 = ((1, 2, 3), 4, 5, (6, 7));
1313
~~~~~~~~~
14-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
14+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
1515
~~~~~~~~~~~~
16-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
16+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
1717
~~~~~~~~~~~~~~~
18-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
18+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
1919
~
20-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
20+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
2121
~~~~
22-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
22+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
2323
~
24-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
24+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
2525
function f1() {
2626
var a = 1;
2727
return a, v1, a;
2828
~
29-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
29+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
3030
~~~~~
31-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
31+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
3232
}
3333

‎tests/baselines/reference/commaOperatorLeftSideUnused.errors.txt‎

Lines changed: 46 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,26 @@
1-
tests/cases/compiler/commaOperatorLeftSideUnused.ts(8,10): error TS2693: Left side of comma operator is unused and has no side effects.
2-
tests/cases/compiler/commaOperatorLeftSideUnused.ts(16,19): error TS2693: Left side of comma operator is unused and has no side effects.
3-
tests/cases/compiler/commaOperatorLeftSideUnused.ts(19,21): error TS2693: Left side of comma operator is unused and has no side effects.
4-
tests/cases/compiler/commaOperatorLeftSideUnused.ts(22,7): error TS2693: Left side of comma operator is unused and has no side effects.
5-
tests/cases/compiler/commaOperatorLeftSideUnused.ts(23,7): error TS2693: Left side of comma operator is unused and has no side effects.
6-
tests/cases/compiler/commaOperatorLeftSideUnused.ts(24,7): error TS2693: Left side of comma operator is unused and has no side effects.
7-
tests/cases/compiler/commaOperatorLeftSideUnused.ts(25,7): error TS2693: Left side of comma operator is unused and has no side effects.
8-
tests/cases/compiler/commaOperatorLeftSideUnused.ts(26,7): error TS2693: Left side of comma operator is unused and has no side effects.
9-
tests/cases/compiler/commaOperatorLeftSideUnused.ts(27,7): error TS2693: Left side of comma operator is unused and has no side effects.
10-
tests/cases/compiler/commaOperatorLeftSideUnused.ts(28,7): error TS2693: Left side of comma operator is unused and has no side effects.
11-
tests/cases/compiler/commaOperatorLeftSideUnused.ts(29,7): error TS2693: Left side of comma operator is unused and has no side effects.
12-
tests/cases/compiler/commaOperatorLeftSideUnused.ts(30,7): error TS2693: Left side of comma operator is unused and has no side effects.
13-
tests/cases/compiler/commaOperatorLeftSideUnused.ts(31,7): error TS2693: Left side of comma operator is unused and has no side effects.
14-
tests/cases/compiler/commaOperatorLeftSideUnused.ts(32,7): error TS2693: Left side of comma operator is unused and has no side effects.
15-
tests/cases/compiler/commaOperatorLeftSideUnused.ts(33,7): error TS2693: Left side of comma operator is unused and has no side effects.
16-
tests/cases/compiler/commaOperatorLeftSideUnused.ts(34,7): error TS2693: Left side of comma operator is unused and has no side effects.
17-
tests/cases/compiler/commaOperatorLeftSideUnused.ts(35,7): error TS2693: Left side of comma operator is unused and has no side effects.
18-
tests/cases/compiler/commaOperatorLeftSideUnused.ts(36,7): error TS2693: Left side of comma operator is unused and has no side effects.
19-
tests/cases/compiler/commaOperatorLeftSideUnused.ts(37,7): error TS2693: Left side of comma operator is unused and has no side effects.
20-
tests/cases/compiler/commaOperatorLeftSideUnused.ts(38,7): error TS2693: Left side of comma operator is unused and has no side effects.
21-
tests/cases/compiler/commaOperatorLeftSideUnused.ts(39,7): error TS2693: Left side of comma operator is unused and has no side effects.
22-
tests/cases/compiler/commaOperatorLeftSideUnused.ts(40,7): error TS2693: Left side of comma operator is unused and has no side effects.
23-
tests/cases/compiler/commaOperatorLeftSideUnused.ts(41,7): error TS2693: Left side of comma operator is unused and has no side effects.
1+
tests/cases/compiler/commaOperatorLeftSideUnused.ts(8,10): error TS2695: Left side of comma operator is unused and has no side effects.
2+
tests/cases/compiler/commaOperatorLeftSideUnused.ts(16,19): error TS2695: Left side of comma operator is unused and has no side effects.
3+
tests/cases/compiler/commaOperatorLeftSideUnused.ts(19,21): error TS2695: Left side of comma operator is unused and has no side effects.
4+
tests/cases/compiler/commaOperatorLeftSideUnused.ts(22,7): error TS2695: Left side of comma operator is unused and has no side effects.
5+
tests/cases/compiler/commaOperatorLeftSideUnused.ts(23,7): error TS2695: Left side of comma operator is unused and has no side effects.
6+
tests/cases/compiler/commaOperatorLeftSideUnused.ts(24,7): error TS2695: Left side of comma operator is unused and has no side effects.
7+
tests/cases/compiler/commaOperatorLeftSideUnused.ts(25,7): error TS2695: Left side of comma operator is unused and has no side effects.
8+
tests/cases/compiler/commaOperatorLeftSideUnused.ts(26,7): error TS2695: Left side of comma operator is unused and has no side effects.
9+
tests/cases/compiler/commaOperatorLeftSideUnused.ts(27,7): error TS2695: Left side of comma operator is unused and has no side effects.
10+
tests/cases/compiler/commaOperatorLeftSideUnused.ts(28,7): error TS2695: Left side of comma operator is unused and has no side effects.
11+
tests/cases/compiler/commaOperatorLeftSideUnused.ts(29,7): error TS2695: Left side of comma operator is unused and has no side effects.
12+
tests/cases/compiler/commaOperatorLeftSideUnused.ts(30,7): error TS2695: Left side of comma operator is unused and has no side effects.
13+
tests/cases/compiler/commaOperatorLeftSideUnused.ts(31,7): error TS2695: Left side of comma operator is unused and has no side effects.
14+
tests/cases/compiler/commaOperatorLeftSideUnused.ts(32,7): error TS2695: Left side of comma operator is unused and has no side effects.
15+
tests/cases/compiler/commaOperatorLeftSideUnused.ts(33,7): error TS2695: Left side of comma operator is unused and has no side effects.
16+
tests/cases/compiler/commaOperatorLeftSideUnused.ts(34,7): error TS2695: Left side of comma operator is unused and has no side effects.
17+
tests/cases/compiler/commaOperatorLeftSideUnused.ts(35,7): error TS2695: Left side of comma operator is unused and has no side effects.
18+
tests/cases/compiler/commaOperatorLeftSideUnused.ts(36,7): error TS2695: Left side of comma operator is unused and has no side effects.
19+
tests/cases/compiler/commaOperatorLeftSideUnused.ts(37,7): error TS2695: Left side of comma operator is unused and has no side effects.
20+
tests/cases/compiler/commaOperatorLeftSideUnused.ts(38,7): error TS2695: Left side of comma operator is unused and has no side effects.
21+
tests/cases/compiler/commaOperatorLeftSideUnused.ts(39,7): error TS2695: Left side of comma operator is unused and has no side effects.
22+
tests/cases/compiler/commaOperatorLeftSideUnused.ts(40,7): error TS2695: Left side of comma operator is unused and has no side effects.
23+
tests/cases/compiler/commaOperatorLeftSideUnused.ts(41,7): error TS2695: Left side of comma operator is unused and has no side effects.
2424

2525

2626
==== tests/cases/compiler/commaOperatorLeftSideUnused.ts (23 errors) ====
@@ -33,7 +33,7 @@ tests/cases/compiler/commaOperatorLeftSideUnused.ts(41,7): error TS2693: Left si
3333
// Should error
3434
case 0, 1:
3535
~
36-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
36+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
3737
return 'zero or one';
3838
default:
3939
return 'more than one';
@@ -43,74 +43,74 @@ tests/cases/compiler/commaOperatorLeftSideUnused.ts(41,7): error TS2693: Left si
4343
// Should error
4444
let x = Math.pow((3, 5), 2);
4545
~
46-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
46+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
4747

4848
// Should error
4949
let a = [(3 + 4), ((1 + 1, 8) * 4)];
5050
~~~~~
51-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
51+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
5252

5353
// Error cases
5454
xx = (1, 2);
5555
~
56-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
56+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
5757
xx = ('', xx);
5858
~~
59-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
59+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
6060
xx = (/323/, 5);
6161
~~~~~
62-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
62+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
6363
xx = (`wat`, 'ok'),
6464
~~~~~
65-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
65+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
6666
xx = (true, false);
6767
~~~~
68-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
68+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
6969
xx = (false, true);
7070
~~~~~
71-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
71+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
7272
xx = (null, xx);
7373
~~~~
74-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
74+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
7575
xx = (undefined, 10);
7676
~~~~~~~~~
77-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
77+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
7878
xx = (() => {}, 'no');
7979
~~~~~~~~
80-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
80+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
8181
xx = (function() { }, 100);
8282
~~~~~~~~
83-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
83+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
8484
xx = ({}, {});
8585
~~
86-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
86+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
8787
xx = (typeof xx, 'unused');
8888
~~~~~~~~~
89-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
89+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
9090
xx = ([1, 2, x++], xx);
9191
~~~~~~~~~~~
92-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
92+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
9393
xx = (xx!, xx);
9494
~~~
95-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
95+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
9696
xx = (xx ? 3 : 4, 10);
9797
~~~~~~~~~~
98-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
98+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
9999
xx = (3 + 4, 10);
100100
~~~~~
101-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
101+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
102102
xx = (!xx, 10);
103103
~~~
104-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
104+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
105105
xx = (~xx, 10);
106106
~~~
107-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
107+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
108108
xx = (-xx, 10);
109109
~~~
110-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
110+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
111111
xx = (+xx, 10);
112112
~~~
113-
!!! error TS2693: Left side of comma operator is unused and has no side effects.
113+
!!! error TS2695: Left side of comma operator is unused and has no side effects.
114114

115115
// OK cases
116116
xx = (xx ? x++ : 4, 10);

0 commit comments

Comments
 (0)