Skip to content

Commit c1911f6

Browse files
committed
Revert "Avoid check for union keys"
This reverts commit d7a7297.
1 parent d7a7297 commit c1911f6

File tree

2 files changed

+3
-53
lines changed

2 files changed

+3
-53
lines changed

src/compiler/checker.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13274,13 +13274,13 @@ namespace ts {
1327413274
undefined;
1327513275
}
1327613276

13277-
function getPropertyTypeForIndexType(originalObjectType: Type, objectType: Type, indexType: Type, fullIndexType: Type, suppressNoImplicitAnyError: boolean, accessNode: ElementAccessExpression | IndexedAccessTypeNode | PropertyName | BindingName | SyntheticExpression | undefined, accessFlags: AccessFlags, reportDeprecated?: boolean) {
13277+
function getPropertyTypeForIndexType(originalObjectType: Type, objectType: Type, indexType: Type, fullIndexType: Type, suppressNoImplicitAnyError: boolean, accessNode: ElementAccessExpression | IndexedAccessTypeNode | PropertyName | BindingName | SyntheticExpression | undefined, accessFlags: AccessFlags) {
1327813278
const accessExpression = accessNode && accessNode.kind === SyntaxKind.ElementAccessExpression ? accessNode : undefined;
1327913279
const propName = accessNode && isPrivateIdentifier(accessNode) ? undefined : getPropertyNameFromIndex(indexType, accessNode);
1328013280
if (propName !== undefined) {
1328113281
const prop = getPropertyOfType(objectType, propName);
1328213282
if (prop) {
13283-
if (reportDeprecated && accessNode && prop.flags & SymbolFlags.Deprecated) {
13283+
if (accessNode && prop.flags & SymbolFlags.Deprecated) {
1328413284
if (getDeprecatedFlags(prop) & (DeprecatedFlags.Type | DeprecatedFlags.Value)) {
1328513285
const deprecatedNode = accessExpression?.argumentExpression ?? (isIndexedAccessTypeNode(accessNode) ? accessNode.indexType : accessNode);
1328613286
errorOrSuggestion(/* isError */ false, deprecatedNode, Diagnostics._0_is_deprecated, propName as string);
@@ -13652,7 +13652,7 @@ namespace ts {
1365213652
}
1365313653
return accessFlags & AccessFlags.Writing ? getIntersectionType(propTypes, aliasSymbol, aliasTypeArguments) : getUnionType(propTypes, UnionReduction.Literal, aliasSymbol, aliasTypeArguments);
1365413654
}
13655-
return getPropertyTypeForIndexType(objectType, apparentObjectType, indexType, indexType, /* supressNoImplicitAnyError */ false, accessNode, accessFlags | AccessFlags.CacheSymbol, /* reportDeprecated */ true);
13655+
return getPropertyTypeForIndexType(objectType, apparentObjectType, indexType, indexType, /* supressNoImplicitAnyError */ false, accessNode, accessFlags | AccessFlags.CacheSymbol);
1365613656
}
1365713657

1365813658
function getTypeFromIndexedAccessTypeNode(node: IndexedAccessTypeNode) {

tests/cases/fourslash/jsdocDeprecated_suggestion4.ts

Lines changed: 0 additions & 50 deletions
This file was deleted.

0 commit comments

Comments
 (0)