Apply suggestions from code review

Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
microsoft · Jun 2, 2021 · cee9f40 · cee9f40
1 parent d3b479e
commit cee9f40
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/compiler/builder.ts b/src/compiler/builder.ts
@@ -856,9 +856,10 @@ namespace ts {
             const optionKey = name.toLowerCase();
             const optionInfo = optionsNameMap.get(optionKey);
             if (optionInfo?.affectsEmit || optionInfo?.affectsSemanticDiagnostics ||
-                // Since we should never compare strict directly between options but individual flag, but it does change value of that flag so store it
+                // We need to store `strict`, even though it won't be examined directly, so that the
+                // flags it controls (e.g. `strictNullChecks`) will be retrieved correctly from the buildinfo
                 optionKey === "strict" ||
-                // These affect if lib files need to be rechecked so store them
+                // We need to store these to determine whether `lib` files need to be rechecked.
                 optionKey === "skiplibcheck" || optionKey === "skipdefaultlibcheck") {
                 (result ||= {})[name] = convertToReusableCompilerOptionValue(
                     optionInfo,