Skip to content

TSServer: NoEmit should be the default for JS files in mixed TS/JS projects #11649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jramsay opened this issue Oct 15, 2016 · 2 comments
Closed

TSServer: NoEmit should be the default for JS files in mixed TS/JS projects #11649

jramsay opened this issue Oct 15, 2016 · 2 comments
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue Visual Studio Integration with Visual Studio
Milestone
TypeScript 2.1

Comments

@jramsay
Copy link
Member

jramsay commented Oct 15, 2016

Emit errors are being generated for JS files in mixed TS/JS projects. NoEmit is already set to true in VS host for JS only projects (projects that only contain JS, script blocks, and d.ts files). We need to handle the NoEmit scenario for JS files in the mixed project scenario.

noemitmixedtsjs
@jramsay jramsay added Bug A bug in TypeScript Visual Studio Integration with Visual Studio Salsa labels Oct 15, 2016
@mhegazy
Copy link
Contributor

mhegazy commented Oct 15, 2016

looks like yet another "default" to set. cc @zhengbli

@mhegazy mhegazy added this to the TypeScript 2.1 milestone Oct 15, 2016
@jramsay
Copy link
Member Author

jramsay commented Oct 15, 2016

@zhengbli: also noticed the same issue for Misc context

@mhegazy mhegazy mentioned this issue Oct 15, 2016
Closed
@mhegazy mhegazy added 2.1 RC and removed 2.1 RC labels Oct 24, 2016
@zhengbli zhengbli mentioned this issue Oct 27, 2016
Merged
@zhengbli zhengbli added the Fixed A PR has been merged for this issue label Oct 28, 2016
@zhengbli zhengbli mentioned this issue Oct 31, 2016
Closed
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue Visual Studio Integration with Visual Studio
Projects
None yet
Milestone
TypeScript 2.1
Development

No branches or pull requests
3 participants
@zhengbli @mhegazy @jramsay