-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distinguish declaration file and js file when the option “Keep comments in TypeScript compiler output" is turned on #11774
Labels
Suggestion
An idea for TypeScript
Too Complex
An issue which adding support for may be too complex for the value it adds
Comments
I wounder if we should just keep comments in .d.ts files all the time, and possibly add |
mhegazy
added
Suggestion
An idea for TypeScript
In Discussion
Not yet reached consensus
labels
Oct 21, 2016
if you do not mind, we would like to keep this open until the issue is addressed. |
dczuo
changed the title
Distinguish declaration file and js file when the option “Keep commons in TypeScript compiler output" is turned on
Distinguish declaration file and js file when the option “Keep comments in TypeScript compiler output" is turned on
Jan 2, 2017
This was referenced Mar 6, 2017
RyanCavanaugh
added
Too Complex
An issue which adding support for may be too complex for the value it adds
and removed
In Discussion
Not yet reached consensus
labels
Mar 14, 2017
Declined for the sake of flag complexity. Running a proper minifier over the output JS is part of any build which cares about output size. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Suggestion
An idea for TypeScript
Too Complex
An issue which adding support for may be too complex for the value it adds
Preserve comments in the declaration file have been able to provide prompt information in VS. Production environment using the uncompressed JS file helps locate exception, and retained in the .js file comments are unnecessary.
Proposals to add the options control only keep comments in declaration files.
The text was updated successfully, but these errors were encountered: