Skip to content

[tsserver] CompileOnSaveEmitFile should returns emited files (js, map, d.ts) path #12124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
angelozerr opened this issue Nov 9, 2016 · 4 comments
Labels
API Relates to the public API for TypeScript Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature Suggestion An idea for TypeScript

Comments

@angelozerr
Copy link

I'm consumming "CompileOnSaveEmitFile " with tsserver inside Eclipse. It works great and improve a lot of performance (before I called tsc when for each save of file and performance was not very good).

In Eclipse, when a file is created outside Eclipse (like tsserver generates js, map files), the files doesn't appear in the Navigator files of the Eclipse. We must do a refresh at hand.

It should be very cool if CompileOnSaveEmitFile could returns the file path for each generated files. With this feature I could refresh those files inside Eclipse.

@angelozerr
Copy link
Author

I think CompileOnSaveEmitFile return nothing because the compilation can take time. It should be very cool if tsserver could send an event with emitted files. Thank's for your help!

@mhegazy mhegazy added Suggestion An idea for TypeScript API Relates to the public API for TypeScript labels Nov 15, 2016
@lorenzodallavecchia
Copy link

Actually, compileOnSaveEmitFile does produce a response message. Is that sent only after files are emitted? In that case, the problem is not compilation time, but just knowing the names of produced files.

Maybe this could be done with a message like compileOnSaveAffectedFileList but for emitted files: something like compileOnSaveEmittedFileList. In that way, no traffic would be added to regular compileOnSave messages.

@RyanCavanaugh
Copy link
Member

@angelozerr do you still need this or can I close it?

@angelozerr
Copy link
Author

Today I'm retrieving emitted files by hard coding that on client side, but it should be better if we could have thoses emtted files.

@RyanCavanaugh RyanCavanaugh added the Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature label Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Relates to the public API for TypeScript Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature Suggestion An idea for TypeScript
Projects
None yet
Development

No branches or pull requests

4 participants