Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: recognize modules within an npm package #12243

Closed
waderyan opened this issue Nov 14, 2016 · 8 comments
Closed

Feature request: recognize modules within an npm package #12243

waderyan opened this issue Nov 14, 2016 · 8 comments
Assignees
Labels
Duplicate An existing issue was already created VS Code Tracked There is a VS Code equivalent to this issue

Comments

@waderyan
Copy link

From @ffxsam on August 31, 2016 2:21

  • VSCode Version: 1.4.0
  • OS Version: Mac OS 10.11.6

It would be awesome if VS Code could do what WebStorm does:

screen_shot_2016-08-30_at_7_13_53_pm__2_

If I have the following:

import {
} from 'material-ui';

and I start typing "Table" in the braces, it can see inside the Material UI package and suggest a list of modules (Table, TableBody, etc).

Copied from original issue: microsoft/vscode#11268

@waderyan
Copy link
Author

From @dbaeumer on August 31, 2016 7:10

@ffxsam is this JavaScript or TypeScript

@waderyan
Copy link
Author

From @ffxsam on August 31, 2016 7:20

JavaScript.

@waderyan
Copy link
Author

This is a valid feature request. Thank you @ffxsam!

@waderyan
Copy link
Author

From @ffxsam on August 31, 2016 16:46

You bet! I come from using WebStorm, which admittedly has probably the best JS code formatting and autocompletion I've seen.. but it suffers from huge bloat, and so I started looking for something more lightweight. VS Code is super impressive so far!

@waderyan
Copy link
Author

@ffxsam can you send me an email? I'm working on the gaps between VS Code and WebStorm and would love to get your feedback in a short 20 minute user interview.

wade.anderson@microsoft.com

@mhegazy
Copy link
Contributor

mhegazy commented Dec 15, 2016

looks like a duplicate of #10092, and should be covered by the suggestion in #7849

@mhegazy mhegazy closed this as completed Dec 15, 2016
@mhegazy mhegazy added the Duplicate An existing issue was already created label Dec 15, 2016
@waderyan
Copy link
Author

@mhegazy I believe this should be reopened. This is a different scenario then #7849 and will not be covered. #7849 is to auto add the imports. This is to receive intellisense for the modules within an npm package.

The user scenario where this is valid is with the popular material-ui library. They have lots and lots of modules in each package. Not having IntelliSense is quite a pain. WebStorm will provide IntelliSense for the modules.

@mhegazy
Copy link
Contributor

mhegazy commented Dec 16, 2016

The original snippet works as intended. and has been working like that for a while so i am not sure i understand what you mean.
animation

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate An existing issue was already created VS Code Tracked There is a VS Code equivalent to this issue
Projects
None yet
Development

No branches or pull requests

2 participants