Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[salsa] [jsdoc] Support for doted properties type assignment in destructive parameters. #15553

Closed
michaeljota opened this issue May 3, 2017 · 2 comments
Labels
Duplicate An existing issue was already created

Comments

@michaeljota
Copy link

TypeScript Version: 2.2.2 (VSCode integrated)

Code

/** Some description
 *
 * @param {PropsType} props The props of the component.
 * @param {string} props.one One property of the props.
 * @param {number} props.two Another property of the props.
 * @return {JSX.Element} A ReactElement.
 */
const SomeReactElement = ({ one, two }) => (
  <div>
    // `one` and `two` should be `string` and `number`, but they are `any`.
  </div>
);

Expected behavior:

Destructive parameters should retain type declaration in JSDoc tags

Actual behavior:

Destructive parameters lose the type definition, and are being declared as any

@mhegazy
Copy link
Contributor

mhegazy commented May 3, 2017

Duplicate of #11597

@mhegazy mhegazy added the Duplicate An existing issue was already created label May 3, 2017
@mhegazy
Copy link
Contributor

mhegazy commented May 19, 2017

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.

@mhegazy mhegazy closed this as completed May 19, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

2 participants