Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property is possibly undefined even after element access/indexed access #16594

Closed
brawaru opened this issue Jun 17, 2017 · 3 comments
Closed
Labels
Duplicate An existing issue was already created

Comments

@brawaru
Copy link

brawaru commented Jun 17, 2017

TypeScript Version: 2.3.4

Code

interface IGuildCustomize {
    /**
     * Welcome message
     */
    welcome_msg?:string;
    /**
     * Channel for welcome message
     */
    welcome_msg_channel:string;
}
let cz = JSON.parse(guildRow.customize) as IGuildCustomize;
if (cz["welcome_msg"] && cz["welcome_msg_channel"]) {
   let channel = msg.guild.channels.get(cz["welcome_msg_channel"]);
   if (!channel || channel.type !== "text") {
    return;
   }
   (channel as TextChannel).send(cz["welcome_msg"].replace("{usermention}", `<@${msg.author.id}>`).replace("{username}", escapeDiscordMarkdown(msg.author.username)));
}

Expected behavior: No errors

Actual behavior: Errors that value possibly can be undefined after if check
image

@brawaru
Copy link
Author

brawaru commented Jun 17, 2017

Works fine this way:
image

@DanielRosenwasser
Copy link
Member

Looks like a duplicate of #10530.

@DanielRosenwasser DanielRosenwasser added the Duplicate An existing issue was already created label Jun 17, 2017
@DanielRosenwasser DanielRosenwasser changed the title Possibly undefined even after if check Property is possibly undefined even after element access/indexed access Jun 17, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Aug 17, 2017

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.

@mhegazy mhegazy closed this as completed Aug 17, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

3 participants