Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StrictNull check Tuple overflow #18253

Closed
sebdoucet opened this issue Sep 5, 2017 · 4 comments
Closed

StrictNull check Tuple overflow #18253

sebdoucet opened this issue Sep 5, 2017 · 4 comments
Labels
Duplicate An existing issue was already created

Comments

@sebdoucet
Copy link

TypeScript Version: 2.4.1

Code

const tuple: [string, number] = ["", 0];
const value = tuple[2];

Expected behavior:
Not compiling. You cant define a type based on what is currently define in the array.
This behavior broke the strict null check validation because this value should be undefined or the accessor non legit.

Actual behavior:
Compile and value as the type of all types defined in the tuple, in this case string | number.

@imcotton
Copy link
Contributor

imcotton commented Sep 5, 2017

When accessing an element outside the set of known indices, a union type is used instead

from: handbook#tuple

@sebdoucet
Copy link
Author

Because it's in the hanbook, that does not make more cense to me.

Why it's not at least a tuple combine with undefined. It broke strict null checking like string | number | undefined

@mhegazy
Copy link
Contributor

mhegazy commented Sep 5, 2017

Duplicate of #6229

@mhegazy mhegazy marked this as a duplicate of #6229 Sep 5, 2017
@mhegazy mhegazy added the Duplicate An existing issue was already created label Sep 5, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Sep 20, 2017

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.

@mhegazy mhegazy closed this as completed Sep 20, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

3 participants