Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib.d.ts: Add Encoding Standard #19062

Closed
saschanaz opened this issue Oct 10, 2017 · 4 comments
Closed

lib.d.ts: Add Encoding Standard #19062

saschanaz opened this issue Oct 10, 2017 · 4 comments
Assignees
@mhegazy
Labels
Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this Suggestion An idea for TypeScript
Milestone
TypeScript 3.0

Comments

@saschanaz
Copy link
Contributor

TypeScript Version: 2.5.x

Code

TextDecoder

Expected behavior: Type should exist

Actual behavior: It doesn't

Spec: https://encoding.spec.whatwg.org/

Matching PR: microsoft/TypeScript-DOM-lib-generator#300
@mhegazy mhegazy added Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Help Wanted You can do this Suggestion An idea for TypeScript labels Oct 11, 2017
@mhegazy mhegazy added this to the Community milestone Oct 11, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Oct 11, 2017

PRs welcomed. You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes.

@saschanaz
Copy link
Contributor Author

Already here 😁 microsoft/TypeScript-DOM-lib-generator#300

@saschanaz
Copy link
Contributor Author

This has been fixed.

@mhegazy mhegazy added the Fixed in TSJS repo Fix merged in https://github.com/Microsoft/TSJS-lib-generator, but not ported yet label Apr 10, 2018
@mhegazy mhegazy self-assigned this Apr 10, 2018
@mhegazy mhegazy modified the milestones: Community, TypeScript 2.9 Apr 10, 2018
@mhegazy mhegazy reopened this Apr 10, 2018
@mhegazy
Copy link
Contributor

mhegazy commented Apr 10, 2018

still need to port the changes from Microsoft/TSJS-lib-generator

@mhegazy mhegazy modified the milestones: TypeScript 2.9, TypeScript 3.0 May 8, 2018
@mhegazy mhegazy mentioned this issue Jun 4, 2018
Merged
@mhegazy mhegazy added Fixed A PR has been merged for this issue and removed Fixed in TSJS repo Fix merged in https://github.com/Microsoft/TSJS-lib-generator, but not ported yet labels Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhegazy mhegazy

Labels
Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this Suggestion An idea for TypeScript
Projects
None yet
Milestone
TypeScript 3.0
Development

No branches or pull requests
2 participants
@saschanaz @mhegazy