Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try-catch statements should be a target of noUnusedParameters #19601

Closed
falsandtru opened this issue Oct 31, 2017 · 2 comments
Closed

Try-catch statements should be a target of noUnusedParameters #19601

falsandtru opened this issue Oct 31, 2017 · 2 comments
Labels
Declined The issue was declined as something which matches the TypeScript vision In Discussion Not yet reached consensus Suggestion An idea for TypeScript

Comments

@falsandtru
Copy link
Contributor

Should use the optional catch clause instead.

TypeScript Version: master

Code

try {
}
catch (_) {
}

Expected behavior:

error

Actual behavior:

pass

@ghost ghost added the Suggestion An idea for TypeScript label Oct 31, 2017
@ghost
Copy link

ghost commented Oct 31, 2017

Seems like a good idea but it would be a breaking change.

@mhegazy
Copy link
Contributor

mhegazy commented Nov 6, 2017

This is a breaking change. This check is a linter check in the first place, and we should not have added them. In the light of our recent discussions about errors vs warnings we should hold off on any of these changes.

@mhegazy mhegazy added the Declined The issue was declined as something which matches the TypeScript vision label Nov 6, 2017
@mhegazy mhegazy closed this as completed Nov 6, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Declined The issue was declined as something which matches the TypeScript vision In Discussion Not yet reached consensus Suggestion An idea for TypeScript
Projects
None yet
Development

No branches or pull requests

2 participants