Skip to content

'Install xyz' QuickFix not properly translated #19626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mjbvz opened this issue Oct 31, 2017 · 3 comments
Closed

'Install xyz' QuickFix not properly translated #19626

mjbvz opened this issue Oct 31, 2017 · 3 comments
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue VS Code Tracked There is a VS Code equivalent to this issue
Milestone
TypeScript 2.7

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Oct 31, 2017

From @chrmarti on October 31, 2017 22:1

  • VSCode Version: Code - Insiders 1.18.0-insider (8dfa696, 2017-10-31T16:36:35.429Z)
  • OS Version: Linux x64 3.13.0-108-generic
  • Extensions: none

Testing #37182

Steps to Reproduce:

  1. code --locale=de

image

Copied from original issue: microsoft/vscode#37352
@mjbvz mjbvz self-assigned this Oct 31, 2017
@mjbvz mjbvz mentioned this issue Oct 31, 2017
Closed
@mjbvz mjbvz added the VS Code Tracked There is a VS Code equivalent to this issue label Oct 31, 2017
@mjbvz mjbvz removed their assignment Oct 31, 2017
@mjbvz
Copy link
Contributor Author

mjbvz commented Oct 31, 2017

Tested with TS 2.6.1. Confirmed that TS error messages are in german but the fix itself is still in english

@mhegazy mhegazy added the Bug A bug in TypeScript label Oct 31, 2017
@mhegazy mhegazy assigned ghost Oct 31, 2017
@mhegazy mhegazy added this to the TypeScript 2.6.2 milestone Oct 31, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Oct 31, 2017

The name of this quickfix is not localizable at the moment. @Andy-MS we need to make this text a diagnostic message so that it is localized.

@ghost ghost mentioned this issue Nov 1, 2017
Merged
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Nov 1, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Nov 1, 2017

We still need to wait on the localized messages for this to light up.

@ghost ghost closed this as completed in #19651 Nov 4, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue VS Code Tracked There is a VS Code equivalent to this issue
Projects
None yet
Milestone
TypeScript 2.7
Development

No branches or pull requests
2 participants
@mhegazy @mjbvz