Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Run install @types quick fix with --no-shrinkwrap #19997

Closed
mjbvz opened this issue Nov 14, 2017 · 3 comments
Closed

[Discussion] Run install @types quick fix with --no-shrinkwrap #19997

mjbvz opened this issue Nov 14, 2017 · 3 comments
Labels
Bug A bug in TypeScript Domain: Quick Fixes Editor-provided fixes, often called code actions. Help Wanted You can do this VS Code Tracked There is a VS Code equivalent to this issue
Milestone

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Nov 14, 2017

From microsoft/vscode#37217

Problem
The install quick fix currently does a normal npm install. For cases where the version of npm used to manage a project is different than the version of npm found in the environment—npm 4 and npm 5 for example—this quick fix can also unexpectedly update the npm-shrinkwrap.json.

Possible solution would be to run the @types install with --no-shrinkwrap


Moving this issue over in case any one else want to weigh in here. We run into this in the VS Code codebase itself because we don't yet support npm 5

@mjbvz mjbvz added the VS Code Tracked There is a VS Code equivalent to this issue label Nov 14, 2017
@mhegazy mhegazy assigned ghost Nov 14, 2017
@mhegazy mhegazy added the Bug A bug in TypeScript label Nov 14, 2017
@mhegazy mhegazy added this to the TypeScript 2.7 milestone Nov 14, 2017
@ghost
Copy link

ghost commented Dec 11, 2017

Should wait on #20619 because most users will want npm's default behavior.

@mhegazy
Copy link
Contributor

mhegazy commented Apr 26, 2018

#20619 is in now. we would be accepting a PR for adding configuration support for the quick fix.

@mhegazy mhegazy added the Help Wanted You can do this label Apr 26, 2018
@mhegazy mhegazy unassigned ghost Apr 26, 2018
@mhegazy mhegazy modified the milestones: TypeScript 2.9, Community Apr 26, 2018
@mhegazy mhegazy added the Domain: Quick Fixes Editor-provided fixes, often called code actions. label Apr 26, 2018
@RyanCavanaugh RyanCavanaugh modified the milestones: Community, Backlog Mar 7, 2019
@mjbvz
Copy link
Contributor Author

mjbvz commented Jan 28, 2020

Closing due to lack of activity in the 2+ years since it was opened

@mjbvz mjbvz closed this as completed Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Domain: Quick Fixes Editor-provided fixes, often called code actions. Help Wanted You can do this VS Code Tracked There is a VS Code equivalent to this issue
Projects
None yet
Development

No branches or pull requests

3 participants