Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad subsequent declaration error #20178

Closed
mhegazy opened this issue Nov 21, 2017 · 0 comments
Closed

Bad subsequent declaration error #20178

mhegazy opened this issue Nov 21, 2017 · 0 comments
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@mhegazy
Copy link
Contributor

mhegazy commented Nov 21, 2017

The current declaration mismatch error looks like:

error TS2403: Subsequent variable declarations must have the same type.  Variable 'items' has type 'DataTransferItemList' at built/local/lib.d.ts 6521:13, but here has type 'DataTransferItem[]'.

The error was introduced by #19356. I do not think this is the correct solution here. the error as it stands is hard to read, and does not lend itself to navigation..

moreover, it makes our baselines very noisy.

I think the correct solution here is to do revert the changes in #19356 and look into
#10489 instead.

@mhegazy mhegazy added the Bug A bug in TypeScript label Nov 21, 2017
@mhegazy mhegazy assigned ghost Nov 21, 2017
@mhegazy mhegazy added this to the TypeScript 2.7 milestone Nov 21, 2017
@ghost ghost closed this as completed in #20206 Nov 29, 2017
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Nov 29, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

1 participant