Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all in file for import fix #20315

Closed
ghost opened this issue Nov 28, 2017 · 2 comments · Fixed by #20338 or #25137
Closed

Fix all in file for import fix #20315

ghost opened this issue Nov 28, 2017 · 2 comments · Fixed by #20338 or #25137
Labels
Bug A bug in TypeScript Domain: Quick Fixes Editor-provided fixes, often called code actions. Fixed A PR has been merged for this issue
Milestone
TypeScript 3.0

Comments

@ghost
Copy link

ghost commented Nov 28, 2017

Issue tracking #14549 for the import fix case. This will be more difficult than others because we'll need to add code to keep track of the imports we're about to add so they can be combined.
@ghost ghost self-assigned this Nov 28, 2017
@mhegazy mhegazy added the Infrastructure Issue relates to TypeScript team infrastructure label Nov 28, 2017
@ghost ghost mentioned this issue Nov 29, 2017
Merged
@ghost ghost closed this as completed in #20338 Dec 7, 2017
@robyoder
Copy link

@andy-ms, in the description for PR #20338 you said that it "Does not fix" this issue, but GH only reads the fix [issue] piece of that and auto-closed this. Should this still be open?

@ghost
Copy link
Author

ghost commented Dec 13, 2017

d'oh, thanks.

@ghost ghost reopened this Dec 13, 2017
@mhegazy mhegazy added Bug A bug in TypeScript and removed Infrastructure Issue relates to TypeScript team infrastructure labels Feb 1, 2018
@mhegazy mhegazy mentioned this issue Feb 1, 2018
Closed
@mhegazy mhegazy added this to the TypeScript 2.9 milestone Apr 12, 2018
@mhegazy mhegazy added the Domain: Quick Fixes Editor-provided fixes, often called code actions. label Apr 26, 2018
@ghost ghost mentioned this issue Jun 21, 2018
Merged
@ghost ghost added the Fixed A PR has been merged for this issue label Jun 21, 2018
@ghost ghost closed this as completed in #25137 Jul 3, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A bug in TypeScript Domain: Quick Fixes Editor-provided fixes, often called code actions. Fixed A PR has been merged for this issue
Projects
None yet
Milestone
TypeScript 3.0
2 participants
@robyoder @mhegazy