Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib.dom.d.ts v2.7.2 contains two reportValidity method definitions #22301

Closed
MaceWindu opened this issue Mar 2, 2018 · 1 comment
Closed

lib.dom.d.ts v2.7.2 contains two reportValidity method definitions #22301

MaceWindu opened this issue Mar 2, 2018 · 1 comment
Assignees
@mhegazy
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue
Milestone
TypeScript 2.8

Comments

@MaceWindu
Copy link

TypeScript Version: 2.7.2

Search Terms: reportValidity

This commit 4c8b979 introduced duplicate reportValidity method definition to lib.dom.d.ts.
BTW, is it ok for compiler be silent here?
@mhegazy
Copy link
Contributor

mhegazy commented Mar 2, 2018

is it ok for compiler be silent here?

yes. as long as the two declarations are identical the compiler allows redeclaration.

Should be fixed by microsoft/TypeScript-DOM-lib-generator#383

@mhegazy mhegazy self-assigned this Mar 2, 2018
@mhegazy mhegazy added this to the TypeScript 2.8 milestone Mar 2, 2018
@mhegazy mhegazy added Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Bug A bug in TypeScript labels Mar 2, 2018
@mhegazy mhegazy closed this as completed Mar 9, 2018
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Mar 9, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mhegazy mhegazy

Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Milestone
TypeScript 2.8
Development

No branches or pull requests
2 participants
@MaceWindu @mhegazy