Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate quickinfo LS requests #24154

Closed
weswigham opened this issue May 16, 2018 · 0 comments · Fixed by #24258
Closed

Truncate quickinfo LS requests #24154

weswigham opened this issue May 16, 2018 · 0 comments · Fixed by #24258
Assignees
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@weswigham
Copy link
Member

To cut down on channel traffic and spend less time doing things the user is likely to discard. @mjbvz recommends a 2000 character cap, with a trailing ... or something if there's more text. We can also approximate this cap while actually building the nodes and use that to estimate when we might be able to bail out of node building early (but still built enough to generate the requisite 2000 characters).

Ref #24140

Oh, @mjbvz can we truncate signature help (#23458), too? Should we have a flag to allow truncation?

@mhegazy mhegazy added the Bug A bug in TypeScript label May 16, 2018
@mhegazy mhegazy added this to the TypeScript 3.0 milestone May 16, 2018
@mhegazy mhegazy modified the milestones: TypeScript 3.0, TypeScript 3.1 Jul 2, 2018
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants