Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node interface #24633

Closed
falsandtru opened this issue Jun 3, 2018 · 1 comment
Closed

Update Node interface #24633

falsandtru opened this issue Jun 3, 2018 · 1 comment
Assignees
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this

Comments

@falsandtru
Copy link
Contributor

TypeScript Version: 3.0.0-dev.201xxxxx

Search Terms:

Code

Expected behavior:

interface Node extends EventTarget {
    readonly childNodes: NodeListOf<Node & ChildNode>;
    readonly firstChild: Node & ChildNode | null;
    readonly lastChild: Node & ChildNode | null;
    readonly nextSibling: Node | null;
    readonly parentElement: Element | null;
    readonly parentNode: Node & ParentNode | null;

Actual behavior:

interface Node extends EventTarget {
    readonly childNodes: NodeListOf<Node & ChildNode>;
    readonly firstChild: Node | null;
    readonly lastChild: Node | null;
    readonly nextSibling: Node | null;
    readonly parentElement: HTMLElement | null;
    readonly parentNode: Node | null;

Playground Link:

Related Issues:
#4689

@mhegazy mhegazy added Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Help Wanted You can do this labels Jun 4, 2018
@mhegazy mhegazy added this to the Community milestone Jun 4, 2018
@mhegazy
Copy link
Contributor

mhegazy commented Jun 4, 2018

PRs welcomed. You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes.

@mhegazy mhegazy added the Fixed in TSJS repo Fix merged in https://github.com/Microsoft/TSJS-lib-generator, but not ported yet label Jun 6, 2018
@mhegazy mhegazy modified the milestones: Community, TypeScript 3.0 Jun 6, 2018
@mhegazy mhegazy self-assigned this Jun 6, 2018
@mhegazy mhegazy reopened this Jun 6, 2018
@mhegazy mhegazy modified the milestones: TypeScript 3.0, TypeScript 3.1 Jul 3, 2018
@mhegazy mhegazy added Fixed A PR has been merged for this issue and removed Fixed A PR has been merged for this issue labels Jul 25, 2018
@mhegazy mhegazy removed the Fixed in TSJS repo Fix merged in https://github.com/Microsoft/TSJS-lib-generator, but not ported yet label Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Projects
None yet
Development

No branches or pull requests

2 participants