Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support folder rename in getEditsForFileRename #24904

Closed
mhegazy opened this issue Jun 12, 2018 · 4 comments
Closed

Support folder rename in getEditsForFileRename #24904

mhegazy opened this issue Jun 12, 2018 · 4 comments
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@mhegazy
Copy link
Contributor

mhegazy commented Jun 12, 2018

Renaming a folder should cause a rename to all files in the project that are part of the folder.

@mhegazy mhegazy added the Bug A bug in TypeScript label Jun 12, 2018
@mhegazy mhegazy assigned ghost Jun 12, 2018
@mhegazy mhegazy added this to the TypeScript 3.0 milestone Jun 12, 2018
@mjbvz
Copy link
Contributor

mjbvz commented Jun 12, 2018

@mhegazy Has this been pushed back from 2.9.2, or this bug tracking a different feature?

@mhegazy
Copy link
Contributor Author

mhegazy commented Jun 12, 2018

there are two parts, 1. changing the folder part of the a file name, that should be working in 2.9.2, but you are still expected to send a file name to the server, 2. sending a folder name directly to the server and the server changing all the files included (that is what this issue is tracking).

@mjbvz
Copy link
Contributor

mjbvz commented Jun 12, 2018

Ok. That makes sense. Thank you for the clarification

I'll make sure VS Code is ready for the 2.9.2 part of this

@ghost ghost added the Fixed A PR has been merged for this issue label Jun 18, 2018
@ghost
Copy link

ghost commented Jun 25, 2018

Fixed by #25052

@ghost ghost closed this as completed Jun 25, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

2 participants