Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending a class of an imported script (<script>) that is typed with TS Defs looses the parameters in the overridden method #26886

Closed
mjbvz opened this issue Sep 4, 2018 · 1 comment
Labels
Duplicate An existing issue was already created

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Sep 4, 2018

From @enjikaka on August 28, 2018 8:33

  • VSCode Version: Version 1.26.1 (1.26.1)
  • OS Version: macOS 10.13.4 (17E199)

Steps to Reproduce:

Reproducible setup and steps here -> https://github.com/enjikaka/type-fail-params-vscode

Copied from original issue: microsoft/vscode#57339

@ghost
Copy link

ghost commented Sep 4, 2018

Duplicate of #23911 -- currently we won't inherit parameter types from a superclass.

@ghost ghost added Duplicate An existing issue was already created and removed Domain: JavaScript The issue relates to JavaScript specifically labels Sep 4, 2018
@mjbvz mjbvz closed this as completed Sep 19, 2018
@mjbvz mjbvz removed their assignment Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

1 participant