-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tsconfig: using out option results in really ugly/duplicated output. #2930
Comments
That would be incorrect because we need to respect initialization order. module m {
export var x = 10;
}
var y = 20;
function f(x: number) {
return 2 * x;
}
module m {
export var z = f(x + y);
} It would be inappropriate to place the initialization of |
I'm not saying you shouldn't respect the initializing order, I'm just saying it feels insane that I need to have duplicated in my single module (one of those per file)... It could just place one around everything in that module file.. Please reopen this.. As you've just increased by javascript file size by N. |
@niemyjski it is true that `var Exceptionless; |
I'm talking about var Exceptionless and extra function wrappers |
I wonder what the extra |
fixing my comment. @niemyjski it is true that |
We have maintained an axiom not to change user code when possible. the problem with merging these scopes, is we will have to rename declarations if they conflict. |
But you are using my tsconfig. That has of all my dependencies so you should have all the info in the parse result to make the right decision. |
closing in favor of #447 |
I'm using a tsconfig file in our project: https://github.com/exceptionless/Exceptionless.Javascript and I'm seeing the following behavior (Everything is in the same module, but multiple files..).
I feel that all code should be placed into the same module region when it's generated.
The text was updated successfully, but these errors were encountered: