-
Notifications
You must be signed in to change notification settings - Fork 12.8k
JavaScript/TypeScript region folding with //region does not work #29379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
(Experimental duplicate detection) |
Verified that it is not working. I can take a shot at fixing this. |
Moved upstream to TypeScript for more feedback since we now use language aware folding. We should wait for more feedback to see if |
@mjbvz I just want to mention that in WebStorm // region is supported by default and // #region might be supported too as you can define custom region expressions there. |
Isn't it done already? |
@ilius33 nope. The docs say so, but it's broken. It's a frustrating issue, because it means that custom code folding is not possible in teams that works with multiple IDEs, nor in open source projects. |
For anyone looking for a solution to this.
// Comment region folding
"maptz.regionfolder": {
"[javascript]": {
"foldStart": "// region [NAME]",
"foldStartRegex": "^[\\s]*//[\\s]*[#]*region[\\s]*(.*)[\\s]*",
"foldEnd": "// endregion",
"foldEndRegex": "^[\\s]*//[\\s]*[#]*endregion",
"foldDefinitions": [
{
"foldStart": "/* region [NAME] */",
"foldStartRegex": "^[\\s]*/\\*[\\s]*[#]*region[\\s]*(.*)[\\s]*\\*/[\\s]*$",
"foldEnd": "/* endregion */",
"foldEndRegex": "/\\*[\\s]*[#]*endregion"
}
]
},
"[javascriptreact]": {
"foldStart": "// region [NAME]",
"foldStartRegex": "^[\\s]*//[\\s]*[#]*region[\\s]*(.*)[\\s]*",
"foldEnd": "// endregion",
"foldEndRegex": "^[\\s]*//[\\s]*[#]*endregion",
"foldDefinitions": [
{
"foldStart": "/* region [NAME] */",
"foldStartRegex": "^[\\s]*/\\*[\\s]*[#]*region[\\s]*(.*)[\\s]*\\*/[\\s]*$",
"foldEnd": "/* endregion */",
"foldEndRegex": "/\\*[\\s]*[#]*endregion"
}
]
},
"[typescript]": {
"foldStart": "// region [NAME]",
"foldStartRegex": "^[\\s]*//[\\s]*[#]*region[\\s]*(.*)[\\s]*",
"foldEnd": "// endregion",
"foldEndRegex": "^[\\s]*//[\\s]*[#]*endregion",
"foldDefinitions": [
{
"foldStart": "/* region [NAME] */",
"foldStartRegex": "^[\\s]*/\\*[\\s]*[#]*region[\\s]*(.*)[\\s]*\\*/[\\s]*$",
"foldEnd": "/* endregion */",
"foldEndRegex": "/\\*[\\s]*[#]*endregion"
}
]
},
"[typescriptreact]": {
"foldStart": "// region [NAME]",
"foldStartRegex": "^[\\s]*//[\\s]*[#]*region[\\s]*(.*)[\\s]*",
"foldEnd": "// endregion",
"foldEndRegex": "^[\\s]*//[\\s]*[#]*endregion",
"foldDefinitions": [
{
"foldStart": "/* region [NAME] */",
"foldStartRegex": "^[\\s]*/\\*[\\s]*[#]*region[\\s]*(.*)[\\s]*\\*/[\\s]*$",
"foldEnd": "/* endregion */",
"foldEndRegex": "/\\*[\\s]*[#]*endregion"
}
]
}
}, This adds support for |
Still not working, and you save my life. god bless you. |
Steps to Reproduce:
//region
and//endregion
in JavaScript and/or TypeScript files to create folding regions.Does this issue occur when all extensions are disabled?: Yes
The release notes for 1.17 mention that support was added for folding regions. For JavaScript/TypeScript, both
//#region
//#endregion
and//region
//endregion
were added. However only//#region
//#endregion
seem to work.//region
//endregion
do not work.This is annoying because some projects I work on use this syntax throughout all the code.
Code snippet
The text was updated successfully, but these errors were encountered: