Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide some sort of diagnostics command in TSServer #31592

Closed
DanielRosenwasser opened this issue May 25, 2019 · 5 comments
Closed

Provide some sort of diagnostics command in TSServer #31592

DanielRosenwasser opened this issue May 25, 2019 · 5 comments
Assignees
Labels
Committed The team has roadmapped this issue Domain: TSServer Issues related to the TSServer Suggestion An idea for TypeScript

Comments

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented May 25, 2019

We often get feedback from VS/VS Code users that TSServer is slow, but the amount of time it takes to diagnose the issue is a bit much for them (e.g. enabling logging etc.)

The proposal here is for TSServer to provide some of the same information as --listFiles and --extendedDiagnostics which you can get from the command line. Editors could then open a buffer that could let them and our teams diagnose issues.

Here's an example of what we could return to the editor:

{
    diagnostics: {
        // ...
    },
    compilerOptions: {
        // ...
    },
    files: [
        { filePath: "...", size: 1234 }
    ]
}

The editor could choose to display this however it wants.

@DanielRosenwasser DanielRosenwasser added Committed The team has roadmapped this issue Domain: TSServer Issues related to the TSServer Suggestion An idea for TypeScript labels May 25, 2019
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 3.6.0 milestone May 25, 2019
@DanielRosenwasser
Copy link
Member Author

@mjbvz @amcasey

@DanielRosenwasser
Copy link
Member Author

Things that might be useful

  • Version
  • Options (e.g. quote style)
  • Projects and what they contain
    • Project kinds (inferred, configured, etc.)
    • include/exclude?
    • file list
    • largest file and its size (maybe just sort files by size)
    • number of files
  • number of errors reported
  • open file list
    • size, longest line length
  • GUIDs of project kinds?

@DanielRosenwasser
Copy link
Member Author

It sounds like editors can just maintain this information as well. Maybe we don't need to do anything in tsserver.

@sheetalkamat
Copy link
Member

Since there was no work needed here, is it safe to close this?

@amcasey
Copy link
Member

amcasey commented Jul 25, 2019

Fine by me. We're tracking the VS work internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Committed The team has roadmapped this issue Domain: TSServer Issues related to the TSServer Suggestion An idea for TypeScript
Projects
None yet
Development

No branches or pull requests

3 participants