Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return outline span for jsdoc comment on es5 method #31786

Closed
mjbvz opened this issue Jun 6, 2019 · 1 comment
Closed

Return outline span for jsdoc comment on es5 method #31786

mjbvz opened this issue Jun 6, 2019 · 1 comment
Labels
Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature Domain: Outlining Relates to multi-line regions that editors can collapse Effort: Moderate Requires experience with the TypeScript codebase, but feasible. Harder than "Effort: Casual". Help Wanted You can do this Suggestion An idea for TypeScript

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Jun 6, 2019

TypeScript Version: 3.5.1

Search Terms:

  • fold / folding
  • outlining
  • jsdoc
  • comment

Code
For the ES5 style javaScript

function Foo() { }

/**
 * @param {string} x Bla
 */
Foo.prototype.bar = function (x) {

};

Expected behavior:
An outline span is return for the jsdoc annotation on method bar

Actual behavior:
No span for the jsdoc comment returned.

Related Issues:

@mjbvz mjbvz mentioned this issue Jun 6, 2019
Closed
@RyanCavanaugh RyanCavanaugh added Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature Suggestion An idea for TypeScript labels Jun 13, 2019
@mjbvz mjbvz added the VS Code Priority Critical issues that VS Code needs fixed in the current TypeScript milestone label Feb 5, 2020
@DanielRosenwasser DanielRosenwasser added Domain: Outlining Relates to multi-line regions that editors can collapse Help Wanted You can do this Effort: Moderate Requires experience with the TypeScript codebase, but feasible. Harder than "Effort: Casual". labels Feb 5, 2020
@mjbvz
Copy link
Contributor Author

mjbvz commented Feb 12, 2020 •
edited
Loading

Closing this in favor of #22732

@mjbvz mjbvz closed this as completed Feb 12, 2020
@mjbvz mjbvz removed the VS Code Priority Critical issues that VS Code needs fixed in the current TypeScript milestone label Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature Domain: Outlining Relates to multi-line regions that editors can collapse Effort: Moderate Requires experience with the TypeScript codebase, but feasible. Harder than "Effort: Casual". Help Wanted You can do this Suggestion An idea for TypeScript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DanielRosenwasser @RyanCavanaugh @mjbvz