Skip to content

Issue use -m system, systemjs cant handle duplicate dependence, They have deleted it #4036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LinboLen opened this issue Jul 27, 2015 · 3 comments
Labels
Bug A bug in TypeScript External Relates to another program, environment, or user action which we cannot control.

Comments

@LinboLen
Copy link

systemjs when there are duplicate dependence in system.register entry,
the problem occur because the below systemjs function

function dedupe(deps) {
  var newDeps = [];
  for (var i = 0, l = deps.length; i < l; i++)
    if (indexOf.call(newDeps, deps[i]) == -1)
      newDeps.push(deps[i])
  return newDeps;
}

They really delete dumplicate dependence, and the system.register dependence array length can't match the setter array then I see a lot of red in my console... ...

#3444 (comment)

fix solution in my local https://github.com/xsilen/TypeScript/commit/751fde222f2973acb04067b95a04daf773974742?diff=unified

@danquirk
Copy link
Member

A minimal repro would be helpful if possible

@danquirk danquirk added the Bug A bug in TypeScript label Jul 27, 2015
@vladima
Copy link
Contributor

vladima commented Jul 27, 2015

should be handled by systemjs/systemjs#623

@mhegazy mhegazy added the External Relates to another program, environment, or user action which we cannot control. label Jul 27, 2015
@mhegazy mhegazy added this to the TypeScript 1.6 milestone Jul 27, 2015
@vladima
Copy link
Contributor

vladima commented Jul 27, 2015

fixed in systemjs/systemjs@7efd6f8

@vladima vladima closed this as completed Jul 27, 2015
@LinboLen LinboLen changed the title Issue use -m system, systemjs cant handle dumplicate dependence, They have deleted it Issue use -m system, systemjs cant handle duplicate dependence, They have deleted it Jul 28, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript External Relates to another program, environment, or user action which we cannot control.
Projects
None yet
Development

No branches or pull requests

4 participants