Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib.es2020.intl.d.ts conflicts with lib.es5.d.ts #42128

Closed
saschanaz opened this issue Dec 27, 2020 · 2 comments Β· Fixed by #42134
Closed

lib.es2020.intl.d.ts conflicts with lib.es5.d.ts #42128

saschanaz opened this issue Dec 27, 2020 · 2 comments Β· Fixed by #42134

Comments

@saschanaz
Copy link
Contributor

saschanaz commented Dec 27, 2020

Bug Report

πŸ”Ž Search Terms DateTimeFormatOptions localeMatcher

πŸ•— Version & Regression Information

⏯ Playground Link

N/A

πŸ’» Code

No code required, build any code with target: es2020

πŸ™ Actual behavior

node_modules/typescript/lib/lib.es2020.intl.d.ts(307,9): error TS2717: Subsequent property declarations must have the same type.  Property 'localeMatcher' must be of type 'string | undefined', but here has type '"lookup" | "best fit" | undefined'.
node_modules/typescript/lib/lib.es2020.intl.d.ts(311,9): error TS2717: Subsequent property declarations must have the same type.  Property 'formatMatcher' must be of type 'string | undefined', but here has type '"basic" | "best fit" | undefined'.
node_modules/typescript/lib/lib.es2020.intl.d.ts(312,9): error TS2717: Subsequent property declarations must have the same type.  Property 'weekday' must be of type 'string | undefined', but here has type '"long" | "short" | "narrow" | undefined'.
node_modules/typescript/lib/lib.es2020.intl.d.ts(313,9): error TS2717: Subsequent property declarations must have the same type.  Property 'era' must be of type 'string | undefined', but here has type '"long" | "short" | "narrow" | undefined'.
node_modules/typescript/lib/lib.es2020.intl.d.ts(314,9): error TS2717: Subsequent property declarations must have the same type.  Property 'year' must be of type 'string | undefined', but here has type '"numeric" | "2-digit" | undefined'.
node_modules/typescript/lib/lib.es2020.intl.d.ts(315,9): error TS2717: Subsequent property declarations must have the same type.  Property 'month' must be of type 'string | undefined', but here has type '"long" | "short" | "narrow" | "numeric" | "2-digit" | undefined'.
node_modules/typescript/lib/lib.es2020.intl.d.ts(316,9): error TS2717: Subsequent property declarations must have the same type.  Property 'day' must be of type 'string | undefined', but here has type '"numeric" | "2-digit" | undefined'.
node_modules/typescript/lib/lib.es2020.intl.d.ts(317,9): error TS2717: Subsequent property declarations must have the same type.  Property 'hour' must be of type 'string | undefined', but here has type '"numeric" | "2-digit" | undefined'.
node_modules/typescript/lib/lib.es2020.intl.d.ts(318,9): error TS2717: Subsequent property declarations must have the same type.  Property 'minute' must be of type 'string | undefined', but here has type '"numeric" | "2-digit" | undefined'.
node_modules/typescript/lib/lib.es2020.intl.d.ts(319,9): error TS2717: Subsequent property declarations must have the same type.  Property 'second' must be of type 'string | undefined', but here has type '"numeric" | "2-digit" | undefined'.
node_modules/typescript/lib/lib.es2020.intl.d.ts(321,9): error TS2717: Subsequent property declarations must have the same type.  Property 'timeZoneName' must be of type 'string | undefined', but here has type '"long" | "short" | undefined'.

πŸ™‚ Expected behavior

No errors

@saschanaz
Copy link
Contributor Author

@batisteo Do you mind to fix it? I think some of your changes should go es5.d.ts instead.

@batisteo
Copy link
Contributor

Right, i'll have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants