Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean literal should be LiteralExpression #42153

Open
Kingwl opened this issue Dec 30, 2020 · 2 comments
Open

Boolean literal should be LiteralExpression #42153

Kingwl opened this issue Dec 30, 2020 · 2 comments
Labels
API Relates to the public API for TypeScript Bug A bug in TypeScript
Milestone

Comments

@Kingwl
Copy link
Contributor

Kingwl commented Dec 30, 2020

Bug Report

Sorry, In my memory there's a duplicate issue about the same problem but I can't find it out.

🔎 Search Terms

API, Boolean, Literal

🕗 Version & Regression Information

  • I was unable to test this on prior versions because It's API

⏯ Playground Link

None

💻 Code

    export interface TrueLiteral extends PrimaryExpression {
        readonly kind: SyntaxKind.TrueKeyword;
    }

    export interface FalseLiteral extends PrimaryExpression {
        readonly kind: SyntaxKind.FalseKeyword;
    }

🙁 Actual behavior

isLiteralExpression(trueLiteral) === false

🙂 Expected behavior

isLiteralExpression(trueLiteral) === true

@MartinJohns
Copy link
Contributor

MartinJohns commented Dec 30, 2020

Sorry, In my memory there's a duplicate issue about the same problem but I can't find it out.

Possibly #26075? You even commented in this issue. :-)

@Kingwl
Copy link
Contributor Author

Kingwl commented Dec 30, 2020

You even commented in this issue. :-)

Thanks! And they seems not duplicated but #40203

@andrewbranch andrewbranch added API Relates to the public API for TypeScript Bug A bug in TypeScript labels Dec 30, 2020
@andrewbranch andrewbranch added this to the Backlog milestone Dec 30, 2020
@Kingwl Kingwl mentioned this issue Feb 4, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Relates to the public API for TypeScript Bug A bug in TypeScript
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants