Skip to content

ResolvedNumberFormatOptions is missing currencySign option #43958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snowystinger opened this issue May 5, 2021 · 0 comments · Fixed by #44006
Closed

ResolvedNumberFormatOptions is missing currencySign option #43958

snowystinger opened this issue May 5, 2021 · 0 comments · Fixed by #44006
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Help Wanted You can do this
Milestone

Comments

@snowystinger
Copy link
Contributor

snowystinger commented May 5, 2021

Bug Report

currencySign is missing from NumberFormatOptions

🔎 Search Terms

currencySign

🕗 Version & Regression Information

I can see it's missing in the types for es5, just as it was added to the options here #40709 I'll create a pull tomorrow hopefully

⏯ Playground Link

Updated Playground link with relevant code

💻 Code

let formatter = new Intl.NumberFormat('en-NZ', { style: 'currency', currency: 'NZD', currencySign: 'accounting' });
formatter.resolvedOptions().currencySign;

🙁 Actual behavior

I get a TS error Property 'currencySign' does not exist on type 'ResolvedNumberFormatOptions'.(2339)

🙂 Expected behavior

I shouldn't get a TS error

@RyanCavanaugh RyanCavanaugh added Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Help Wanted You can do this labels May 5, 2021
@RyanCavanaugh RyanCavanaugh added this to the Backlog milestone May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Help Wanted You can do this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants