Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexed access type isn't taking information from conditional into account #44387

Closed
sigurdschneider opened this issue Jun 2, 2021 · 3 comments
Labels
Duplicate An existing issue was already created

Comments

@sigurdschneider
Copy link

Bug Report

🔎 Search Terms

index type, indexed access type, index access operator, extends, Exclude, conditional type

🕗 Version & Regression Information

This is the behavior in every version I tried (3.3.3 to 4.3.2), and I reviewed the FAQ for entries about indexed access types.

⏯ Playground Link

Playground link with relevant code

💻 Code

interface A {
    details1?: {y:string};
    details2?: {x:string};
}

function create<PropName extends keyof A>(
    name: PropName , a: A): Exclude<A[PropName], undefined> {
    const x: A[PropName] = a[name];
    if (x) return x; // Type error: Type 'A[PropName]' is not assignable to type 'Exclude<A[PropName], undefined>'.
    throw new Error();
}

🙁 Actual behavior

TypeScript complains that x in if (x) return x; is of type 'A[PropName]' and is not assignable to type 'Exclude<A[PropName], undefined>', because it assumes that x can be undefined.

🙂 Expected behavior

I would have expected that this works, as return x is the consequence of the conditional if (x), so x cannot be undefined.

Thanks for taking the time to look at this!

@RyanCavanaugh RyanCavanaugh added the Duplicate An existing issue was already created label Jun 2, 2021
@RyanCavanaugh
Copy link
Member

Duplicate #31908 & others. We'd need, at a minimum, #22348 to be able to model this correctly.

@sigurdschneider
Copy link
Author

Too bad, thanks for taking a look.

@typescript-bot
Copy link
Collaborator

This issue has been marked as a 'Duplicate' and has seen no recent activity. It has been automatically closed for house-keeping purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

3 participants