Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go-to-definition doesn't work on non-module packages #44497

Open
DanielRosenwasser opened this issue Jun 8, 2021 · 2 comments
Open

Go-to-definition doesn't work on non-module packages #44497

DanielRosenwasser opened this issue Jun 8, 2021 · 2 comments
Labels
Bug A bug in TypeScript Domain: Symbol Navigation Relates to go-to-definition, find-all-references, highlighting/occurrences. Effort: Moderate Requires experience with the TypeScript codebase, but feasible. Harder than "Effort: Casual". Help Wanted You can do this
Milestone

Comments

@DanielRosenwasser
Copy link
Member

If you have @types/node installed, you might naively try to go-to-definition on node in the following code if you're trying to understand things better.

import "node";

Similarly to what used to happen with go-to-definition on a non-module file (#41861), we don't find a corresponding symbol for the module and just give up.

However, we were able to get this partially working for relative source files in #42539. We should be able to still make this work for package files as well.

@DanielRosenwasser DanielRosenwasser added Bug A bug in TypeScript Domain: Symbol Navigation Relates to go-to-definition, find-all-references, highlighting/occurrences. Effort: Moderate Requires experience with the TypeScript codebase, but feasible. Harder than "Effort: Casual". Help Wanted You can do this labels Jun 8, 2021
@DanielRosenwasser DanielRosenwasser added this to the Backlog milestone Jun 8, 2021
@vikene
Copy link

vikene commented Jun 12, 2021

Hello @DanielRosenwasser , if no one is working on this bug. can I give it a stab ?

@DanielRosenwasser
Copy link
Member Author

Sure, though as a warning I think it's not likely to be an easy bug to get right in a clean way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Domain: Symbol Navigation Relates to go-to-definition, find-all-references, highlighting/occurrences. Effort: Moderate Requires experience with the TypeScript codebase, but feasible. Harder than "Effort: Casual". Help Wanted You can do this
Projects
None yet
Development

No branches or pull requests

2 participants