Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New help displays misleading/wrong default value for useDefineForClassFields #45503

Closed
MartinJohns opened this issue Aug 18, 2021 · 0 comments · Fixed by #45513
Closed

New help displays misleading/wrong default value for useDefineForClassFields #45503

MartinJohns opened this issue Aug 18, 2021 · 0 comments · Fixed by #45513
Assignees
@orta
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue
Milestone
TypeScript 4.5.0

Comments

@MartinJohns
Copy link
Contributor

Bug Report

🔎 Search Terms

useDefineForClassFields

🕗 Version & Regression Information

  • I was unable to test this on prior versions because this new help display is introduced with version 4.4.

💻 Code

Execute this command: npx typescript@4.4.1-rc --help --all

🙁 Actual behavior

The default value false is shown for useDefineForClassFields.

image

🙂 Expected behavior

The default value depends on the target (it's true for ESNext since TypeScript 4.3, introduced in #34787).
This should be reflected in the help.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orta orta

Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue
Projects
None yet
Milestone
TypeScript 4.5.0
Development

Successfully merging a pull request may close this issue.

Fix the default text for --useDefineForClassFields orta/TypeScript
4 participants
@orta @MartinJohns @RyanCavanaugh @typescript-bot