You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The module transform turned all of our top-level namespaces into modules.
However, some notable exceptions are ts.Debug and the parser (and some other minor examples; search for ^namespace ).
Debug is used nearly everywhere in the code, but calls to the namespace cannot be scope lifted by esbuild. Converting debug.ts into something reexported like export * as Debug from "./debug.ts" would work the same, but all calls would get lifted and become direct, which may have a performance win like the rest of the scope lifting did.
The parser has fewer calls across the namespace barrier, however it contains some duplicated allocators and this may aid in converting the parser into a self-contained tree-shakable entity for #34617.
The text was updated successfully, but these errors were encountered:
jakebailey
changed the title
Convert ts.Debug, Parser, etc from namespaces into a modules
Convert ts.Debug, Parser, etc from namespaces into modules
Jan 12, 2023
The module transform turned all of our top-level namespaces into modules.
However, some notable exceptions are
ts.Debug
and the parser (and some other minor examples; search for^namespace
).Debug
is used nearly everywhere in the code, but calls to the namespace cannot be scope lifted by esbuild. Convertingdebug.ts
into something reexported likeexport * as Debug from "./debug.ts"
would work the same, but all calls would get lifted and become direct, which may have a performance win like the rest of the scope lifting did.The parser has fewer calls across the namespace barrier, however it contains some duplicated allocators and this may aid in converting the parser into a self-contained tree-shakable entity for #34617.
The text was updated successfully, but these errors were encountered: