Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export TypingsInstaller types from tsserverlibrary #53414

Closed
5 tasks done
zkat opened this issue Mar 21, 2023 · 0 comments Β· Fixed by #53394
Closed
5 tasks done

export TypingsInstaller types from tsserverlibrary #53414

zkat opened this issue Mar 21, 2023 · 0 comments Β· Fixed by #53394
Assignees
Labels
API Relates to the public API for TypeScript Domain: TSServer Issues related to the TSServer

Comments

@zkat
Copy link
Member

zkat commented Mar 21, 2023

Suggestion

πŸ” Search Terms

List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily and help provide feedback.

βœ… Viability Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion

I'd like to export the interfaces and such that would be needed to implement TypingsInstaller when only using tsserverlibrary. Currently, the necessary types are only available for full tsserver.

πŸ“ƒ Motivating Example

I want to be able to implement TypingsInstaller on the web.

πŸ’» Use Cases

TypingsInstaller on the web.

@DanielRosenwasser DanielRosenwasser added API Relates to the public API for TypeScript Domain: TSServer Issues related to the TSServer labels Mar 21, 2023
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 5.1.0 milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Relates to the public API for TypeScript Domain: TSServer Issues related to the TSServer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants