Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

currentScript property not exists in Document interface #5533

Closed
emilgpa opened this issue Nov 4, 2015 · 6 comments
Closed

currentScript property not exists in Document interface #5533

emilgpa opened this issue Nov 4, 2015 · 6 comments
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Milestone
TypeScript 1.8

Comments

@emilgpa
Copy link

emilgpa commented Nov 4, 2015

The currentScript not exists in Document interface.
@mhegazy mhegazy added Bug A bug in TypeScript Help Wanted You can do this labels Nov 4, 2015
@mhegazy
Copy link
Contributor

mhegazy commented Nov 4, 2015

A PR would be appreciated. here is some information about submitting a lib.d.ts PR: https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes

@mhegazy mhegazy added the Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript label Nov 4, 2015
@mhegazy mhegazy added this to the Community milestone Nov 4, 2015
@emilgpa
Copy link
Author

emilgpa commented Nov 5, 2015

Ok. Nice. I will do it now!

@emilgpa emilgpa mentioned this issue Nov 5, 2015
Closed
@zhengbli zhengbli mentioned this issue Nov 6, 2015
Merged
@zhengbli zhengbli closed this as completed Nov 6, 2015
@zhengbli zhengbli reopened this Nov 6, 2015
@zhengbli
Copy link
Contributor

zhengbli commented Nov 6, 2015

This is fixed in microsoft/TypeScript-DOM-lib-generator#17

@mhegazy
Copy link
Contributor

mhegazy commented Nov 6, 2015

@zhengbli should we close this? Or you want to do a port first?

@mhegazy mhegazy modified the milestones: TypeScript 1.8, Community Nov 6, 2015
@zhengbli
Copy link
Contributor

zhengbli commented Nov 6, 2015

@mhegazy I think these issues should be closed only when the changes are checked in the TypeScript repo. It might be easier to track if we can add a new label to these ones, something like "Fixed in TSJS" so we can close them in batch when syncing with that repo.

@mhegazy
Copy link
Contributor

mhegazy commented Nov 6, 2015

Sounds good.

@zhengbli zhengbli mentioned this issue Nov 30, 2015
Merged
@zhengbli zhengbli added Fixed A PR has been merged for this issue and removed Fixed in TSJS repo labels Dec 1, 2015
@zhengbli zhengbli closed this as completed Dec 1, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Projects
None yet
Milestone
TypeScript 1.8
Development

No branches or pull requests
3 participants
@zhengbli @emilgpa @mhegazy