Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextMate grammar does not highlight regex following comment. #5663

Closed
basarat opened this issue Nov 13, 2015 · 5 comments
Closed

TextMate grammar does not highlight regex following comment. #5663

basarat opened this issue Nov 13, 2015 · 5 comments
Labels
External Relates to another program, environment, or user action which we cannot control.

Comments

@basarat
Copy link
Contributor

basarat commented Nov 13, 2015

Sample from : microsoft/TypeScript-TmLanguage#3

let regex = /**/ /foo/;

image
@mhegazy mhegazy added the Bug A bug in TypeScript label Nov 13, 2015
@mhegazy
Copy link
Contributor

mhegazy commented Nov 13, 2015

PRs welcomed.

@mhegazy mhegazy added the Help Wanted You can do this label Nov 13, 2015
@DanielRosenwasser
Copy link
Member

What's the bug here? This looks correct.

@basarat
Copy link
Contributor Author

basarat commented Nov 13, 2015

@DanielRosenwasser yes ... Its fine in the referenced tm grammar as well 🌹

image

Just that I expected this result to be different from textmate result which I assumed to be a bug and hence thought this was a 🐛

@basarat basarat closed this as completed Nov 13, 2015
@basarat
Copy link
Contributor Author

basarat commented Nov 13, 2015

Ahhh textmate version should have shown yellow like a string literal

image

textmate version still has the bug. No bug here 🌹

@DanielRosenwasser DanielRosenwasser added External Relates to another program, environment, or user action which we cannot control. and removed Help Wanted You can do this Bug A bug in TypeScript labels Nov 13, 2015
@DanielRosenwasser
Copy link
Member

See microsoft/TypeScript-TmLanguage#3.

@DanielRosenwasser DanielRosenwasser changed the title getEncodedSyntacticClassifications invalid on multiline-commented regex TextMate grammar does not highlight regex following comment. Nov 13, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
External Relates to another program, environment, or user action which we cannot control.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@basarat @DanielRosenwasser @mhegazy