Skip to content

Convert params to destructed object: Cannot apply refactoring #58930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tyriar opened this issue Jun 19, 2024 · 2 comments · May be fixed by #59140
Open

Convert params to destructed object: Cannot apply refactoring #58930

Tyriar opened this issue Jun 19, 2024 · 2 comments · May be fixed by #59140
Assignees
@iisaduan
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue
Milestone
TypeScript 5.6.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 19, 2024

Repro:

  1. Go to buffer.ts
  2. Put cursor in static wrap
  3. ctrl+.
  4. Select convert params code action

Recording 2024-06-19 at 06 48 54
@mjbvz mjbvz transferred this issue from microsoft/vscode Jun 19, 2024
@mjbvz mjbvz removed their assignment Jun 19, 2024
@RyanCavanaugh RyanCavanaugh added the Needs More Info The issue still hasn't been fully clarified label Jun 20, 2024
@RyanCavanaugh
Copy link
Member

@Tyriar please transcribe the screenshot, indicate where "buffer.ts" is, or provide an isolated repro. Thanks!

@Tyriar
Copy link
Member Author

Tyriar commented Jun 21, 2024

@RyanCavanaugh https://github.com/microsoft/vscode/blob/b03fd7c49878d0431ab57d803c3f1f0f9a3488ed/src/vs/base/common/buffer.ts#L36

@RyanCavanaugh RyanCavanaugh added Bug A bug in TypeScript and removed Needs More Info The issue still hasn't been fully clarified labels Jun 21, 2024
@RyanCavanaugh RyanCavanaugh added this to the TypeScript 5.6.0 milestone Jun 21, 2024
@iisaduan iisaduan linked a pull request Jul 4, 2024 that will close this issue
Draft
@typescript-bot typescript-bot added the Fix Available A PR has been opened for this issue label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iisaduan iisaduan

Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue
Projects
None yet
Milestone
TypeScript 5.6.0
Development

Successfully merging a pull request may close this issue.

allow more cases to not block convert params to destructured object refactor iisaduan/TypeScript
5 participants
@Tyriar @RyanCavanaugh @mjbvz @iisaduan @typescript-bot