Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running go to definition on export and other keywords #60308

Open
mjbvz opened this issue Oct 22, 2024 · 1 comment Β· May be fixed by #60384
Open

Allow running go to definition on export and other keywords #60308

mjbvz opened this issue Oct 22, 2024 · 1 comment Β· May be fixed by #60384
Assignees
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Oct 22, 2024

πŸ”Ž Search Terms

  • go to definition

πŸ•— Version & Regression Information

Not a regression

⏯ Playground Link

No response

πŸ’» Code

export class A {

    private z: string;

    readonly x: string;

    async a() {  }

    override b() {}
}

Try running go to definition or go to type definition on any of the keywords before the symbol name (export, private, override, async)

πŸ™ Actual behavior

No definitions fourd

πŸ™‚ Expected behavior

It should work the same as running go to definition on the symbol name

Additional information about the issue

No response

@mjbvz
Copy link
Contributor Author

mjbvz commented Oct 22, 2024

This is something that we run into with copilot's symbols links. I'm working on trying to make sure we always talk about the actual symbol's location instead of the range of the entire definition but thought it was worth bringing up for TS too

@RyanCavanaugh RyanCavanaugh added the Bug A bug in TypeScript label Oct 30, 2024
@RyanCavanaugh RyanCavanaugh added this to the TypeScript 5.8.0 milestone Oct 30, 2024
@typescript-bot typescript-bot added the Fix Available A PR has been opened for this issue label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants