Rename members does not work on type argument values

[tinganho]

interface A {
    a: string;
}
function f(): Promise<A> {
    return Promise.resolve({
        a: '',
    });
}

Renaming A.a to A.b doesn't work on above example.

[tinganho]

The cursor could also be in both places. Both yield error result.

[DanielRosenwasser]

This is because we can't figure out Promise<A> is the type returned by Promise.resolve - it's just Promise<{ a: string }> which is structurally compatible. @RyanCavanaugh don't we have an issue for use-sites as an inference site for type arguments? I can't find it.

We should also consider a "Rename all structurally compatible types." option for rename.

[mhegazy]

We talked about this before, not sure if there is an issue for this though.

[mhegazy]

@DanielRosenwasser wanna file an issue for it?

[DanielRosenwasser]

Which issue specifically? Structural references, or adding inference sites?

[mhegazy]

structural references.

[DanielRosenwasser]

Done. See #6388.

[mhegazy]

We can close this one then?

[DanielRosenwasser]

Yup. The inference site idea was #5254 for future reference.