Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read compilation settings from package.json #6590

Closed
Brocco opened this issue Jan 23, 2016 · 4 comments
Closed

Read compilation settings from package.json #6590

Brocco opened this issue Jan 23, 2016 · 4 comments
Labels
Revisit An issue worth coming back to Suggestion An idea for TypeScript

Comments

@Brocco
Copy link

Brocco commented Jan 23, 2016

The tsconfig.json file was introduced around version 1.5 (or so) to store TypeScript compilation settings.

Proposal: leave configuration values being pulled from that file as the default but if it doesn't exist instead of just passing directly to no command options, attempt to pull the settings from package.json under a key of typescript

This is similar to the ideas posed in issue #4090 but instead of creating another config file it would just utilize a configuration file that already exists in a large number of projects.

@vladima vladima added this to the TypeScript 1.8 milestone Jan 25, 2016
@mhegazy mhegazy added Suggestion An idea for TypeScript Revisit An issue worth coming back to labels Jan 27, 2016
@mhegazy mhegazy removed this from the TypeScript 1.8 milestone Jan 27, 2016
@mhegazy
Copy link
Contributor

mhegazy commented Jan 27, 2016

while I do agree that package.json is a nice place to keep all your configuration, I do not see the value of adding yet another variation (we have 2 already, tsconfig, and command line arguments). so I would punt on this one for now. assuming we have enough user demand we can revisit.

@tivac
Copy link

tivac commented Feb 1, 2017

microsoft/vscode#13786

I find this outcome pretty disappointing.

@pygy
Copy link

pygy commented Feb 1, 2017

@tivac indeed... These config files are pure noise to me as well.

@CraigPhillips
Copy link

+1 - would get used on my team as well.

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Revisit An issue worth coming back to Suggestion An idea for TypeScript
Projects
None yet
Development

No branches or pull requests

6 participants