Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default module to commonjs #6807

Closed
mhegazy opened this issue Feb 2, 2016 · 2 comments · Fixed by #7034
Closed

Change default module to commonjs #6807

mhegazy opened this issue Feb 2, 2016 · 2 comments · Fixed by #7034
Assignees
@billti
Labels
Committed The team has roadmapped this issue Suggestion An idea for TypeScript
Milestone
TypeScript 1.8.2

Comments

@mhegazy
Copy link
Contributor

mhegazy commented Feb 2, 2016

As noted in #6735, the default --module flag should be commonJs and not none.
@mhegazy mhegazy added Bug A bug in TypeScript Salsa labels Feb 2, 2016
@mhegazy mhegazy added this to the Salsa 0.9 milestone Feb 2, 2016
@mhegazy mhegazy added Suggestion An idea for TypeScript Committed The team has roadmapped this issue and removed Bug A bug in TypeScript labels Feb 2, 2016
@mhegazy mhegazy mentioned this issue Feb 2, 2016
Closed
@mhegazy mhegazy modified the milestones: Salsa 0.9, TypeScript 1.8.2 Feb 2, 2016
@zhengbli zhengbli mentioned this issue Feb 2, 2016
Closed
@mhegazy mhegazy assigned billti and unassigned zhengbli Feb 11, 2016
@billti billti mentioned this issue Feb 11, 2016
Merged
@mhegazy mhegazy mentioned this issue Feb 11, 2016
Closed
@mikekidder
Copy link

Hey, just wanted to say.... you guys are awesome!! Really enjoying all the new functionality in VSCode and Typescript. Thanks!

@billti
Copy link
Member

billti commented Feb 11, 2016

Fixed in #7016

@billti billti closed this as completed Feb 11, 2016
@billti billti mentioned this issue Feb 11, 2016
Merged
@egamma egamma mentioned this issue Feb 29, 2016
Closed
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@billti billti

Labels
Committed The team has roadmapped this issue Suggestion An idea for TypeScript
Projects
None yet
Milestone
TypeScript 1.8.2
Development

Successfully merging a pull request may close this issue.

Port CommonJs as default module type, and adds default exclude values microsoft/TypeScript
4 participants
@mikekidder @billti @zhengbli @mhegazy