Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to Definition is not working for simple js object #6839

Closed
egamma opened this issue Feb 2, 2016 · 5 comments
Closed

Go to Definition is not working for simple js object #6839

egamma opened this issue Feb 2, 2016 · 5 comments
Assignees
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@egamma
Copy link
Member

egamma commented Feb 2, 2016

From @yboukhata on February 2, 2016 13:16

Hi,

The Go to Definition seems not working for object methods.

In this example, clicking on Go to Definition in obj.method does anything.

var obj = {};

obj.method = function() {
    return true;
};

obj.method();

I think that it is a bug in Go to Definition.

Copied from original issue: microsoft/vscode#2641

@egamma
Copy link
Member Author

egamma commented Feb 2, 2016

This is also not supported in 0.10.7 with Salsa enabled. Moving to Salsa for comment.

@mhegazy mhegazy added Bug A bug in TypeScript Salsa labels Feb 2, 2016
@mhegazy mhegazy added this to the TypeScript 1.8.2 milestone Feb 2, 2016
@RyanCavanaugh RyanCavanaugh removed this from the TypeScript 1.8.2 milestone Feb 2, 2016
@RyanCavanaugh RyanCavanaugh removed the Bug A bug in TypeScript label Feb 2, 2016
@RyanCavanaugh
Copy link
Member

We don't support this pattern.

@RyanCavanaugh RyanCavanaugh removed their assignment Feb 2, 2016
@mhegazy
Copy link
Contributor

mhegazy commented Feb 3, 2016

thanks @RyanCavanaugh.

@mhegazy mhegazy closed this as completed Feb 3, 2016
@mhegazy mhegazy added the By Design Deprecated - use "Working as Intended" or "Design Limitation" instead label Feb 3, 2016
@sandersn sandersn removed the By Design Deprecated - use "Working as Intended" or "Design Limitation" instead label Nov 28, 2017
@sandersn sandersn reopened this Nov 28, 2017
@sandersn
Copy link
Member

#20198 or a subsequent PR should handle this pattern. It currently handles it when var obj = {} is in another file, but not when it's in the same file, so it's probably just a small tweak needed.

@sandersn sandersn self-assigned this Nov 28, 2017
@mhegazy mhegazy added this to the TypeScript 2.7 milestone Nov 28, 2017
@mhegazy mhegazy added the Bug A bug in TypeScript label Nov 28, 2017
@mhegazy mhegazy modified the milestones: TypeScript 2.7, TypeScript 2.8 Jan 9, 2018
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Mar 9, 2018
@mhegazy
Copy link
Contributor

mhegazy commented Mar 9, 2018

Fixed by #21974

@mhegazy mhegazy closed this as completed Mar 9, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

4 participants