-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arrow syntax missing a closure in ES5 #9408
Comments
Looks like #7334, which is fixed in |
^ I've been using nightlies the entire time and verified it with the above build. The diagnostic message is working but I'm ignoring it because support is on the roadmap. Would it be fixed another way? |
With the currently nightly, if your target is ES5, then the expression The bug in v1.8 was not the invalid emitted code, it was the lack of error message. v1.8 didn't support |
Yes the diagnostic message is working but the 2.0 roadmap indicates planned support in #1564. I assume there's a bigger architectural theme but I've been using Regenerator with |
Yeah, I'd say the current emit is not a bug since there are no guarantees about emitted code when there are compile errors. The v2.0 milestone is currently at 96% completion, so if you wait a little longer you'll be able to target ES5 and get valid emitted code. However it won't look much like your |
Okay I understood that's the probable resolution. When I set up our build a few months ago I was silencing several diagnostics and you've already made all the rest work. Thanks! |
TypeScript Version: 1.8.0 / nightly (
2.0.0-dev.20160628
)I'm currently using
async
in ES5 from the compiler service (similar to #1564 (comment)) via Regenerator. Could #7706 be fixed since it's on the 2.0 roadmap?Code
ES2015:
Actual ES5:
Expected ES5:
CC @spicydonuts
The text was updated successfully, but these errors were encountered: