Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[X-CLIP] SampleFrames possible wrong arguments? #110

Open
pha123661 opened this issue Jul 30, 2023 · 0 comments
Open

[X-CLIP] SampleFrames possible wrong arguments? #110

pha123661 opened this issue Jul 30, 2023 · 0 comments

Comments

@pha123661
Copy link

pha123661 commented Jul 30, 2023 •
edited
Loading

Hi,

Thanks for the excellent work. However, in this line of the dataloader:

VideoX/X-CLIP/datasets/build.py

Line 249 in 71ef17a

dict(type='SampleFrames', clip_len=1, frame_interval=1, num_clips=config.DATA.NUM_FRAMES),

The arguments are clip_len=1, num_clips=config.DATA.NUM_FRAMES. Shouldn't it be clip_len=config.DATA.NUM_FRAMES, frame_interval=1, num_clips=1?

Or did I miss something?

I look forward to your response, thanks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pha123661